Feature updates and new README#3
Open
Bob620 wants to merge 1 commit into
Open
Conversation
feat(readme) updated readme to current workflow feat(restart_server.sh) changed to use python3 by default
perimosocordiae
requested changes
Sep 23, 2019
|
|
||
| mkdir superman | ||
| cd superman | ||
| git clone https://github.com/all-umass/superman-web |
Member
There was a problem hiding this comment.
I think it may be easier to keep the two repositories separate:
pip3 install git+https://github.com/all-umass/superman.git
git clone https://github.com/all-umass/superman-web
cd superman-web
pip3 install matplotlib tornado==4.4.2 pyyaml h5py pandas pywt sklearn
| ### 1: Install Dependencies | ||
|
|
||
| pip install --only-binary :all: superman matplotlib tornado pyyaml h5py pandas | ||
| While 2.7 and 3.4+ are supported, I've only tested with 3.4+ |
Member
There was a problem hiding this comment.
Our primary deployment is still using 2.7, so both are tested.
| Several Python packages are needed, available from PyPI via `pip`: | ||
|
|
||
| For running tests, you'll want: | ||
| pip3 install matplotlib tornado==4.4.2 pyyaml h5py pandas pywt sklearn |
Member
There was a problem hiding this comment.
Ideally we should put these in a requirements.txt file, but that can come later.
| for k, cls, mname in info.get('metadata', [])] | ||
| if info.get('vector', False): | ||
| loader_fn = _generic_vector_loader(meta_mapping) | ||
| if entries: |
Member
There was a problem hiding this comment.
To avoid indenting everything here, you can do:
if not entries:
continue
| geoiplookup $1 | sed 1d | cut -d: -f2 | cut -d' ' -f3- | cut -d, -f2,3 | xargs | ||
| geoiplookup $1 | sed 1d | cut -d: -f2 | \ | ||
| cut -d' ' -f3- | cut -d, -f2,3 | \ | ||
| tr "'" '^' | xargs |
Member
There was a problem hiding this comment.
What's the replacement of ' with ^ for?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat(restart_server.sh) Defaults to python3 rather than python
feat(README.md) Updated readme due to workflow update
feat(backend/dataset_loaders.py) Operates with a blank dataset file if no pre-defined datasets exist