feat(provider): add default timeout for PendingTransactionConfig#3771
Open
TanayK07 wants to merge 3 commits intoalloy-rs:mainfrom
Open
feat(provider): add default timeout for PendingTransactionConfig#3771TanayK07 wants to merge 3 commits intoalloy-rs:mainfrom
TanayK07 wants to merge 3 commits intoalloy-rs:mainfrom
Conversation
Set DEFAULT_PENDING_TX_TIMEOUT (5 minutes) as the default timeout for pending transaction watchers instead of None, preventing calls from hanging indefinitely when a transaction is never confirmed. Users can still disable the timeout with `.with_timeout(None)`. Closes alloy-rs#3104
TanayK07
requested review from
DaniPopes,
klkvr,
mattsse and
onbjerg
as code owners
Contributor
Author
|
hi @mattsse could you review this once when you get the chance |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DEFAULT_PENDING_TX_TIMEOUTconstant (5 minutes) as the default timeout forPendingTransactionConfigPendingTransactionConfig::new()to useSome(DEFAULT_PENDING_TX_TIMEOUT)instead ofNone.with_timeout(None)Previously,
PendingTransactionConfigdefaulted totimeout: None, meaning pending transaction watchers could hang indefinitely if a transaction was never confirmed. This sets a reasonable default while preserving the ability to opt out.Closes #3104
Test plan
cargo build -p alloy-providerpassescargo clippy -p alloy-providerclean (no warnings)cargo fmt --checkpasses