fix(provider): default create_access_list to pending#3890
Open
Shresth79 wants to merge 1 commit intoalloy-rs:mainfrom
Open
fix(provider): default create_access_list to pending#3890Shresth79 wants to merge 1 commit intoalloy-rs:mainfrom
Shresth79 wants to merge 1 commit intoalloy-rs:mainfrom
Conversation
Shresth79
requested review from
DaniPopes,
grandizzy,
klkvr,
mattsse,
onbjerg and
zerosnacks
as code owners
Contributor
Author
|
The new create_access_list regression test passes locally; the remaining failure is test_anvil_set_time, which looks unrelated to this PR. |
mattsse
reviewed
Apr 15, 2026
Comment on lines
248
to
+252
| fn create_access_list<'a>( | ||
| &self, | ||
| request: &'a N::TransactionRequest, | ||
| ) -> RpcWithBlock<&'a N::TransactionRequest, AccessListResult> { | ||
| self.client().request("eth_createAccessList", request).into() | ||
| RpcWithBlock::new_rpc(self.client().request("eth_createAccessList", request)).pending() |
Member
There was a problem hiding this comment.
since this is for accesslist, maybe we should keep this unchanged, but I think pending is actually more correct ehre
Contributor
Author
There was a problem hiding this comment.
@mattsse Thanks for the review! I was mainly trying to keep create_access_list in line with call, since
StorageSlotFinder uses both and the differing defaults can cause context drift. If you’d rather keep
the change narrower, I can limit it to the StorageSlotFinder call site.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
StorageSlotFinder::find_slotcollects candidate slots witheth_createAccessListand then validates them witheth_call. The former defaulted tolatestwhile the latter defaulted topending, so plain providers could compare two different state contexts and miss the correct slot.Solution
Default
Provider::create_access_listto the pending block so it matcheseth_callwhile still allowing explicit.latest()/.block_id(...)overrides. Clarify the provider docs, add a focused unit test for the new default, and document thatStorageSlotFinderfollows the provider's default block context.PR Checklist