Restrict editing of system serving config attachments #1389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it more obvious what's gone when generating several objects from the same factory, and avoids collisions on unique fields.
This adds a new scope (`.user_editable`) and corresponding predicate method (`#user_editable?`) to `ServingConfig` to define whether a serving config is "user editable". Users can edit `live` or `preview` serving configs, but not `system` ones (which can only be modified programatically, for example by Search Admin scripts). They're still viewable in the UI though.
This scopes the `ControlAttachmentsController` to only allow editing of control attachments for serving configs that are user editable, and removes the edit link from the show pages of those that aren't.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our serving configs have different use cases, one of which is
system. These are internal serving configs that we want don't want users to be able to attach controls or otherwise edit.This adds a scope and predicate for the concept of
user_editableserving configs, restricts theControlAttachmentsControllerto only allow edit/update for editable serving configs, and removes the "Manage attached controls" link for those that aren't.