Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fireface: latter: fix eq gain range #195

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fireface: latter: fix eq gain range #195

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions protocols/fireface/src/latter.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1278,9 +1278,9 @@ impl AsMut<FfLatterEqState> for FfLatterOutputEqualizerParameters {
/// The trait for specification of equalizer.
pub trait RmeFfLatterEqualizerSpecification {
/// The minimum value of gain.
const EQ_GAIN_MIN: i32 = -20;
const EQ_GAIN_MIN: i32 = -200;
/// The maximum value of gain.
const EQ_GAIN_MAX: i32 = 20;
const EQ_GAIN_MAX: i32 = 200;
/// The step value of gain.
const EQ_GAIN_STEP: i32 = 1;

Expand Down
9 changes: 8 additions & 1 deletion runtime/fireface/src/latter_ctls.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1216,6 +1216,13 @@ where
const EQ_HIGH_FREQ_NAME: &'static str;
const EQ_HIGH_QUALITY_NAME: &'static str;

const EQ_GAIN_TLV: DbInterval = DbInterval {
min: -2000,
max: 2000,
linear: false,
mute_avail: false,
};

fn params(&self) -> &U;
fn params_mut(&mut self) -> &mut U;

Expand Down Expand Up @@ -1270,7 +1277,7 @@ where
T::EQ_GAIN_MAX,
T::EQ_GAIN_STEP,
Self::CH_COUNT,
None,
Some(&Vec::<u32>::from(&Self::EQ_GAIN_TLV)),
true,
)
.map(|mut list| elem_id_list.append(&mut list))
Expand Down