fixed incorrect SignColumn's background color on theme dark. #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
not my screen shot, but same situation:here |
|
Yes, I've got same situation. and I post a snapshot. the left one is the original while the right one the edition. |
|
@waveform, @winsphinx, I fixed this in my fork. You might want to check it out: https://github.com/ericbn/vim-solarized |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure the patch is correct or not. But, at least, it fixed the incorrect background color for SignColumn on dark theme ( terminal, not gui ). Would you please help to check it if you have time? Thanks very much.