Skip to content

Comments

CSS Cleanup + Auto Dark Mode#9

Open
espimarisa wants to merge 2 commits intoaltrac-works:mainfrom
espimarisa:main
Open

CSS Cleanup + Auto Dark Mode#9
espimarisa wants to merge 2 commits intoaltrac-works:mainfrom
espimarisa:main

Conversation

@espimarisa
Copy link

CSS Cleanup + Dark Mode Support

This implements an automatic dark theme for the website dependent on the user's system theme settings (the default is still light mode, however). This also cleans up and restructures the main stylesheet, as well as some other small improvements.

Please god review my changes locally because I'm sure some weird edge case that I somehow missed exploded.

image

Features

  • Added an automatic dark theme that kicks in if the user has their browser/system to dark mode

Accessibility improvements

  • Append alt text to current images
  • Use rem when possible instead of em/px
  • Added a slight hover opacity change on buttons/links with hidden text-decoration
  • Slightly more consistent nav link spacing instead of forcing a specific amount of px
  • Improved consistency of system font fallbacks for users that force their own browser font

Chores

  • Fixed a few little jank CSS things here and there
  • Massively restructured/cleaned up the CSS stylesheet and attributes
  • Added an inline development server bash script because I'm forgetful
  • Updated gitattributes to properly store binary files as binary in case of jank
  • Formatted everything consistently (if you want spaces, edit .editorconfig and re-format

Copy link
Contributor

@an-empty-string an-empty-string left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pretty cool! and sorry for the delay here. I think @hfuller wants to have a look before we merge anything, and I have a few nits I am going to poke at myself before we merge too (probably dropping the non-relevant filetypes from .gitattributes and .editorconfig to keep things tidy, unless you have any objections there)

this is also reminding me that we need to drop old pages (collect) and convert some of them to soupault generation (print)

largely looks lgtm to me though!

@espimarisa
Copy link
Author

espimarisa commented Apr 1, 2025

thank you! - absolutely agree with you on all of it as well. my bad for including the HUGE dotfiles i accidentally used my global ones. i went ahead and pushed a commit to clean it up :)

also agree on converting the older pages as well, things are a bit messy internally and it'd be nice to clean it up.

if you want me to fix something or a nitpick as well, you can do so or just ask me to do so here or on discord.

pretty cool! and sorry for the delay here. I think @hfuller wants to have a look before we merge anything, and I have a few nits I am going to poke at myself before we merge too (probably dropping the non-relevant filetypes from .gitattributes and .editorconfig to keep things tidy, unless you have any objections there)

this is also reminding me that we need to drop old pages (collect) and convert some of them to soupault generation (print)

largely looks lgtm to me though!

This commit ammends the original pull request and only changes what was necessary. Thanks, Prettier.
@espimarisa espimarisa reopened this Jul 1, 2025
@espimarisa
Copy link
Author

Sorry for the spammy PR - I'm not having a great day with computers.

I went ahead and amended the PR so it doesn't apply so many random markup changes that I somehow didn't notice or pay attention to.

Only the CSS was updated, alongside appending alt-text to the ALTRAC logo, adding watch.sh for a nasty little bash wrapper, and adding .gitattributes back.

pls hire me i am pro developer. thamk u.

@espimarisa
Copy link
Author

@hfuller we kinda forgor...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants