-
Notifications
You must be signed in to change notification settings - Fork 69
Add Graph and DataSetGenerator integration tests #524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Create test_graph_integration.py with 4 tests covering Graph.build_async, save/load JSON roundtrip, and cycle detection for OpenAI and Gemini - Create test_generator_integration.py with 6 tests covering basic generation, topic model integration, async generation, chain-of-thought, and file saving - Add Makefile targets: test-integration-graph, test-integration-generator - Use shared fixtures from conftest.py for provider configuration Signed-off-by: Luke Hinds <[email protected]>
Summary of ChangesHello @lukehinds, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the project's test coverage by introducing a comprehensive suite of integration tests for the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds valuable integration tests for the Graph and DataSetGenerator components, covering core functionalities like building, saving/loading, and data generation with different providers (OpenAI and Gemini). The tests are well-structured and cover important use cases. I've made a few suggestions to improve code clarity and consistency in the new test files, mainly around how async operations are handled and ensuring test data is consistent.
- Use generator consumption pattern instead of list comprehension for unused events - Replace "placeholder" with actual topic variable for consistent graph state Signed-off-by: Luke Hinds <[email protected]>
Graph.build_async, save/load JSON roundtrip, and cycle detection for OpenAI and Geminitest_generator_integration.pywith 6 tests covering basic generation, topic model integration, async generation, chain-of-thought, and file savingtest-integration-graph,test-integration-generatorconftest.pyfor provider configuration