Skip to content

vendor._siliconblue: fix off-by-1 with default_clk = "SB_LFOSC"#1650

Merged
whitequark merged 1 commit intoamaranth-lang:mainfrom
whitequark:SB_LFOSC-off-by-1
Jan 13, 2026
Merged

vendor._siliconblue: fix off-by-1 with default_clk = "SB_LFOSC"#1650
whitequark merged 1 commit intoamaranth-lang:mainfrom
whitequark:SB_LFOSC-off-by-1

Conversation

@whitequark
Copy link
Member

This bug caused all logic in the sync domain to be optimized out, as the reset ended up being continuously asserted.

@whitequark whitequark enabled auto-merge December 29, 2025 14:15
@codecov
Copy link

codecov bot commented Jan 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.28%. Comparing base (3a3bf81) to head (40ba283).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1650   +/-   ##
=======================================
  Coverage   91.28%   91.28%           
=======================================
  Files          44       44           
  Lines       11478    11478           
  Branches     2237     2237           
=======================================
  Hits        10478    10478           
  Misses        837      837           
  Partials      163      163           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@whitequark whitequark added this pull request to the merge queue Jan 13, 2026
Merged via the queue into amaranth-lang:main with commit 777e58e Jan 13, 2026
44 of 86 checks passed
@whitequark whitequark deleted the SB_LFOSC-off-by-1 branch January 13, 2026 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant