vendor._siliconblue: fix off-by-1 with default_clk = "SB_LFOSC"#1650
Merged
whitequark merged 1 commit intoamaranth-lang:mainfrom Jan 13, 2026
Merged
vendor._siliconblue: fix off-by-1 with default_clk = "SB_LFOSC"#1650whitequark merged 1 commit intoamaranth-lang:mainfrom
default_clk = "SB_LFOSC"#1650whitequark merged 1 commit intoamaranth-lang:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1650 +/- ##
=======================================
Coverage 91.28% 91.28%
=======================================
Files 44 44
Lines 11478 11478
Branches 2237 2237
=======================================
Hits 10478 10478
Misses 837 837
Partials 163 163 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Merged
via the queue into
amaranth-lang:main
with commit Jan 13, 2026
777e58e
44 of 86 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This bug caused all logic in the
syncdomain to be optimized out, as the reset ended up being continuously asserted.