Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/81 routing #82

Merged
merged 4 commits into from
Dec 30, 2024
Merged

Fix/81 routing #82

merged 4 commits into from
Dec 30, 2024

Conversation

JohnCoene
Copy link
Collaborator

This should fix #81

@JohnCoene JohnCoene added the bug Something isn't working label Dec 30, 2024
@JohnCoene JohnCoene self-assigned this Dec 30, 2024
Copy link
Contributor

@kennedymwavu kennedymwavu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this fixes the issue. please have a look at the 2 comments i left.

R/request.R Outdated Show resolved Hide resolved
R/routing.R Outdated Show resolved Hide resolved
@JohnCoene
Copy link
Collaborator Author

Yes indeed, thanks for that!

Copy link
Contributor

@kennedymwavu kennedymwavu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@JohnCoene JohnCoene merged commit a6f5089 into master Dec 30, 2024
5 of 8 checks passed
@JohnCoene JohnCoene deleted the fix/81-routing branch December 30, 2024 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

improve route parameter handling and error reporting
2 participants