You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I found that the macro ament_add_gtest_executable seems to not use the newer keyword style of linking:
IIUC the keyword argument probably doesn't matter for executable targets since no downstream target is going to link against it, but CMake probably still requires it to be all keyword based or all plain (CMP0023). We could change this to PRIVATE on Rolling so it works with macros that pass a keyword argument to target_link_libraries().
In relation to comment here:
ros2/rosidl#400 (comment)
I found that the macro
ament_add_gtest_executable
seems to not use the newer keyword style of linking:ament_cmake/ament_cmake_gtest/cmake/ament_add_gtest_executable.cmake
Lines 52 to 54 in 799183a
Relates #383
\cc @sloretz @IanTheEngineer
The text was updated successfully, but these errors were encountered: