-
Notifications
You must be signed in to change notification settings - Fork 369
Fix overriding of install #510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 26, 2023
c375281
to
e416c5f
Compare
Signed-off-by: Tyler Weaver <[email protected]>
e416c5f
to
c4b50d1
Compare
Co-authored-by: Chris Thrasher <[email protected]>
Co-authored-by: Chris Thrasher <[email protected]>
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## master #510 +/- ##
==========================================
- Coverage 35.78% 32.48% -3.31%
==========================================
Files 189 7 -182
Lines 17570 665 -16905
Branches 11592 357 -11235
==========================================
- Hits 6287 216 -6071
+ Misses 994 157 -837
+ Partials 10289 292 -9997
Flags with carried forward coverage won't be shown. Click here to find out more.
|
destogl
approved these changes
Jan 27, 2023
bmagyar
approved these changes
Feb 10, 2023
fmauch
pushed a commit
to fmauch/ros2_controllers
that referenced
this pull request
May 11, 2023
* Fix overriding of install Signed-off-by: Tyler Weaver <[email protected]> * Update admittance_controller/CMakeLists.txt Co-authored-by: Chris Thrasher <[email protected]> * Update ros2_controllers/CMakeLists.txt Co-authored-by: Chris Thrasher <[email protected]> * Remove unused lists * Use THIS_PACKAGE_INCLUDE_DEPENDS list --------- Signed-off-by: Tyler Weaver <[email protected]> Co-authored-by: Chris Thrasher <[email protected]>
bmagyar
pushed a commit
that referenced
this pull request
May 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to:
Here are the colcon docs on overriding: https://colcon.readthedocs.io/en/released/user/overriding-packages.html#how-to-make-it-easier-for-your-users-to-override
Here is the ament_cmake user guide: https://docs.ros.org/en/rolling/How-To-Guides/Ament-CMake-Documentation.html