Skip to content

Fix overriding of install #510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 10, 2023
Merged

Conversation

tylerjw
Copy link
Contributor

@tylerjw tylerjw commented Jan 26, 2023

Signed-off-by: Tyler Weaver <[email protected]>
@codecov-commenter
Copy link

Codecov Report

Merging #510 (476ad91) into master (e7f9962) will decrease coverage by 3.31%.
The diff coverage is 26.60%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master     #510      +/-   ##
==========================================
- Coverage   35.78%   32.48%   -3.31%     
==========================================
  Files         189        7     -182     
  Lines       17570      665   -16905     
  Branches    11592      357   -11235     
==========================================
- Hits         6287      216    -6071     
+ Misses        994      157     -837     
+ Partials    10289      292    -9997     
Flag Coverage Δ
unittests 32.48% <26.60%> (-3.31%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ontroller/test/test_load_diff_drive_controller.cpp 12.50% <0.00%> (ø)
diff_drive_controller/src/odometry.cpp 42.16% <11.11%> (ø)
diff_drive_controller/src/speed_limiter.cpp 46.55% <11.11%> (ø)
...ive_controller/test/test_diff_drive_controller.cpp 17.62% <12.08%> (ø)
...troller/include/diff_drive_controller/odometry.hpp 20.00% <20.00%> (ø)
...iff_drive_controller/src/diff_drive_controller.cpp 39.22% <35.50%> (ø)
...de/diff_drive_controller/diff_drive_controller.hpp 100.00% <100.00%> (ø)
...ory_controller/test/test_trajectory_controller.cpp
...nt_state_controller/src/joint_state_controller.cpp
...test/test_load_joint_group_velocity_controller.cpp
... and 191 more

@bmagyar bmagyar merged commit 2ce1f21 into ros-controls:master Feb 10, 2023
fmauch pushed a commit to fmauch/ros2_controllers that referenced this pull request May 11, 2023
* Fix overriding of install

Signed-off-by: Tyler Weaver <[email protected]>

* Update admittance_controller/CMakeLists.txt

Co-authored-by: Chris Thrasher <[email protected]>

* Update ros2_controllers/CMakeLists.txt

Co-authored-by: Chris Thrasher <[email protected]>

* Remove unused lists

* Use THIS_PACKAGE_INCLUDE_DEPENDS list

---------

Signed-off-by: Tyler Weaver <[email protected]>
Co-authored-by: Chris Thrasher <[email protected]>
bmagyar pushed a commit that referenced this pull request May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants