Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CMakeLists.txt #31

Merged
merged 1 commit into from
Jan 16, 2025
Merged

Update CMakeLists.txt #31

merged 1 commit into from
Jan 16, 2025

Conversation

mosfet80
Copy link

@mosfet80 mosfet80 commented Jan 9, 2025

set correct cmake minimum version for googletest 1.15.

https://github.com/google/googletest/blob/v1.15.0/CMakeLists.txt

set correct cmake minimum version for googletest 1.15.

https://github.com/google/googletest/blob/v1.15.0/CMakeLists.txt

Signed-off-by: mosfet80 <[email protected]>
Copy link

@sloretz sloretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's nothing wrong with this change, but this package is a little odd. The CMakeLists.txt that this PR edits doesn't really matter. It's the CMakeLists.txt.install that actually get's used to build googletest.

@sloretz
Copy link

sloretz commented Jan 16, 2025

Pulls: #31
Gist: https://gist.githubusercontent.com/sloretz/d660f1af17c4c82402184d1488d5f316/raw/5d091cff33249b532207f688f247ff753e3ecc10/ros2.repos
BUILD args: --packages-up-to rmw
TEST args: --packages-select rmw
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/15066

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@sloretz sloretz merged commit a79ad9c into ament:rolling Jan 16, 2025
1 of 4 checks passed
@sloretz sloretz mentioned this pull request Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants