feat: add extend deadline functionality for mentee submissions#103
feat: add extend deadline functionality for mentee submissions#103tejasai2007 wants to merge 9 commits into
Conversation
There was a problem hiding this comment.
Please go through the comments @tejasai2007 , and give explanation
looking forward!
| raise HTTPException(status_code=400, detail="Task Already Extended") | ||
| return extended | ||
|
|
||
| @router.patch("/update-extend-deadline", response_model= ExtendOut) |
There was a problem hiding this comment.
can you brief me about why update-extend-deadline is needed and hows it different from extend-deadline , and why does it need a separate end point
why can not it be included in the extend-deadline, or maybe add a conditional logic
| db.refresh(submission) | ||
| return submission | ||
|
|
||
| def submit_task(db: Session, submission_id: int,reference_link:str): |
There was a problem hiding this comment.
shouldnt we have a logic to reject tasks when the deadline is crossed
There was a problem hiding this comment.
this part i was planning to commit in issue #97
| ''' | ||
|
|
||
|
|
||
| def extend_date(db:Session,extended_date:date,submission_id:int,reason:str,mentor_id :int): |
There was a problem hiding this comment.
how are we exactly extending the date, are we calculating the no.days needed for the task to be complete from the start date and then extending the days to the result we've got? if so I dont see the code to it
| db.commit() | ||
| db.refresh(extended) | ||
| return extended | ||
| def update_extend_date(db:Session,extended_date:date,extended_id : int): |
There was a problem hiding this comment.
i dont think update_extend_date is needed, i dont get why this is here
|
@tejasai2007 please do mention the issue this pr solves |
|
This pr is to resolve issue #91 |
tejasai2007
force-pushed
the
extend
branch
4 times, most recently
from
5b6c8ea to
2c359b9
Compare
tejasai2007
force-pushed
the
extend
branch
2 times, most recently
from
9d53d29 to
87c201b
Compare
2 participants
This PR adds backend support for extending mentee task submission deadlines, enabling mentors or administrators to modify deadline dates during emergency or unexpected situations.