Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PyPi test and upload action #107

Merged
merged 2 commits into from
Nov 19, 2024
Merged

Fix PyPi test and upload action #107

merged 2 commits into from
Nov 19, 2024

Conversation

Giulero
Copy link
Collaborator

@Giulero Giulero commented Nov 18, 2024

The pypi action fails with:

Unable to download artifact(s): Artifact not found for name: dist
        Please ensure that your artifact is not expired and the artifact was uploaded using a compatible version of toolkit/upload-artifact.
        For more information, visit the GitHub Artifacts FAQ: https://github.com/actions/toolkit/blob/main/packages/artifact/docs/faq.md

This PR wants to solve this (but I'm not sure it works).
I should also change the logic triggering the test_PyPi, ideally with and additional manual trigger.
See: https://github.com/actions/download-artifact?tab=readme-ov-file#download-multiple-filtered-artifacts-to-the-same-directory


📚 Documentation preview 📚: https://adam-docs--107.org.readthedocs.build/en/107/

@Giulero
Copy link
Collaborator Author

Giulero commented Nov 19, 2024

Thanks @traversaro! I've a question. Do you know how to set up a manual trigger for this action?

@traversaro
Copy link
Contributor

Thanks @traversaro! I've a question. Do you know how to set up a manual trigger for this action?

In general you need to add a workflow_dispatch: under on: . @flferretti may know more.

@flferretti
Copy link
Contributor

Thanks @traversaro! I've a question. Do you know how to set up a manual trigger for this action?

In general you need to add a workflow_dispatch: under on: . @flferretti may know more.

Correct! You can just add that under the section on. See for example https://github.com/ami-iit/jaxsim/blob/main/.github/workflows/pixi.yml#L8

@Giulero Giulero changed the title Change upload logic. See https://github.com/actions/download-artifact… Fix PyPi test and upload action Nov 19, 2024
@Giulero
Copy link
Collaborator Author

Giulero commented Nov 19, 2024

Thanks @flferretti and @traversaro! Added workflow_dispatch under on: in 2bbf85e.

I guess I can trigger the workflow once merged!

@Giulero Giulero merged commit 92058fc into main Nov 19, 2024
16 checks passed
@Giulero Giulero deleted the Giulero-patch-1 branch November 19, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants