Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up comments and typing #114

Merged
merged 22 commits into from
Jan 3, 2025
Merged
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
39aabbc
Fix wrong comments
Giulero Dec 27, 2024
21b1a81
Update copyright notices to remove year specification
Giulero Dec 27, 2024
8682e2b
Update copyright notice to remove year specification
Giulero Dec 27, 2024
f8e5c8a
Remove unused import from core module
Giulero Dec 30, 2024
5f476dc
Update copyright notices to remove year specification
Giulero Dec 30, 2024
eb710bb
isort imports. Substitute List with list and similar.
Giulero Dec 30, 2024
97f814f
Fix return type
Giulero Dec 30, 2024
b5b839b
Fix another return type
Giulero Dec 30, 2024
5ca24e5
Fix stupid typo
Giulero Dec 30, 2024
8ddbf04
Specify type for graph attribute and improve error message for multip…
Giulero Jan 2, 2025
c8adbbc
Refactor model to use property for link number instead of post init
Giulero Jan 2, 2025
a8b110c
Deprecate root_link parameter in casadi KinDynComputations constructo…
Giulero Jan 2, 2025
931bfaa
Deprecate root_link parameter in jax KinDynComputations constructors …
Giulero Jan 2, 2025
3f6b84b
Deprecate root_link parameter in numpy KinDynComputations constructor…
Giulero Jan 2, 2025
f8596e0
Deprecate root_link parameter in casadi KinDynComputationsParametric…
Giulero Jan 2, 2025
f60e4e0
Deprecate root_link parameter in jax KinDynComputationsParametric con…
Giulero Jan 2, 2025
e8b4be3
Deprecate root_link parameter in numpy KinDynComputationsParametric c…
Giulero Jan 2, 2025
ac697b8
Deprecate root_link parameter in pytorch KinDynComputationsParametric…
Giulero Jan 2, 2025
8b39b3c
Deprecate root_link parameter in pytorch KinDynComputations construct…
Giulero Jan 2, 2025
d665eae
Comply with black
Giulero Jan 2, 2025
3b46c9f
Investigate if moving the import solves the circular import
Giulero Jan 2, 2025
af95f33
Revert back Isorting
Giulero Jan 3, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Deprecate root_link parameter in pytorch KinDynComputationsParametric…
… constructor and update documentation
Giulero committed Jan 2, 2025
commit ac697b8674af9bc81a95c27f373f01920391f2d7
8 changes: 6 additions & 2 deletions src/adam/parametric/pytorch/computations_parametric.py
Original file line number Diff line number Diff line change
@@ -20,7 +20,7 @@ def __init__(
urdfstring: str,
joints_name_list: list,
links_name_list: list,
root_link: str = "root_link",
root_link: str = None,
gravity: np.array = torch.tensor(
[0, 0, -9.80665, 0, 0, 0], dtype=torch.float64
),
@@ -30,14 +30,18 @@ def __init__(
urdfstring (str): either path or string of the urdf
joints_name_list (list): list of the actuated joints
links_name_list (list): list of parametric links
root_link (str, optional): the first link. Defaults to 'root_link'.
root_link (str, optional): Deprecated. The root link is automatically chosen as the link with no parent in the URDF. Defaults to None.
"""
self.math = SpatialMath()
self.g = gravity
self.links_name_list = links_name_list
self.joints_name_list = joints_name_list
self.urdfstring = urdfstring
self.representation = Representations.MIXED_REPRESENTATION # Default
if root_link is not None:
raise DeprecationWarning(
"The root_link argument is not used. The root link is automatically chosen as the link with no parent in the URDF"
)

def set_frame_velocity_representation(
self, representation: Representations