New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dhruv/MT5Defaulting/password-modal-styling/TRAH-3963 #113

Closed

Dhruv-deriv wants to merge 10 commits into amina-deriv:dhruv/amina_mt5_defaulting_jurisdiction from Dhruv-deriv:dhruv/MT5Defaulting/password-modal-styling

Dhruv-deriv commented Aug 13, 2024 •

edited

Loading

Changes:

To style the new password modal in MT5-new Account creation
To create the Mobile view for the new MT5 Account Creation Password model.
Created test cases for Mt5CreatePassword Modal

Screenshot:

Desktop view:

Screenshot 2024-08-15 at 8 50 31 AM

Mobile view:

Screenshot 2024-08-23 at 2 10 30 PM

Test cases


          fix: added styling to password modal

b3da5a8

Dhruv-deriv requested review from hirad-deriv and matin-deriv as code owners

August 13, 2024 09:40

amina-deriv reviewed

View reviewed changes

packages/cfd/src/sass/mt5-passwordmodal.scss Outdated Show resolved Hide resolved

amina-deriv reviewed

View reviewed changes

packages/cfd/src/sass/mt5-passwordmodal.scss Outdated Show resolved Hide resolved

amina-deriv reviewed

View reviewed changes

packages/cfd/src/sass/mt5-passwordmodal.scss Outdated Show resolved Hide resolved

amina-deriv reviewed

View reviewed changes

packages/cfd/src/sass/mt5-passwordmodal.scss Outdated Show resolved Hide resolved

amina-deriv reviewed

View reviewed changes

packages/cfd/src/sass/mt5-passwordmodal.scss Outdated Show resolved Hide resolved


          fix: added border and adjusted gap between components

c53fd23

Dhruv-deriv requested a review from maryia-deriv as a code owner

August 14, 2024 11:20

Dhruv-deriv added 3 commits

August 14, 2024 16:28


          fix: adjusted the size of the modal

7f20567


          fix: resolved comments1

d540d22


          fix: resolved commits2

309d96a

Dhruv-deriv changed the title ~~Added styling to password modal~~ dhruv/TRAH-3963/Added styling to password modal

Dhruv-deriv added 2 commits

August 15, 2024 15:35


          Merge branch 'dhruv/amina_mt5_defaulting_jurisdiction' of github.com:…

42d719a

…amina-deriv/deriv-app into dhruv/MT5Defaulting/password-modal-styling


          fix: merged with master and updated code

a6c8a1c

amina-deriv reviewed

View reviewed changes

packages/cfd/src/Containers/mt5-create-password/mt5-create-password.scss Outdated Show resolved Hide resolved

amina-deriv reviewed

View reviewed changes

packages/cfd/src/Containers/mt5-create-password/mt5-create-password.scss Outdated Show resolved Hide resolved

amina-deriv reviewed

View reviewed changes

packages/cfd/src/Containers/mt5-create-password/mt5-create-password.scss Outdated Show resolved Hide resolved

amina-deriv reviewed

View reviewed changes

packages/components/src/components/modal/modal.scss Show resolved Hide resolved

amina-deriv reviewed

View reviewed changes

packages/components/src/components/modal/modal.tsx Show resolved Hide resolved

Dhruv-deriv added 3 commits

August 19, 2024 10:58


          fix: added button mobile size

af2ae98


          Merge branch 'dhruv/amina_mt5_defaulting_jurisdiction' into dhruv/MT5…

84ea91a

…Defaulting/password-modal-styling


          fix: added test cases for MT5CreatePassword

Dhruv-deriv changed the title ~~dhruv/TRAH-3963/Added styling to password modal~~ dhruv/MT5Defaulting/password-modal-styling/TRAH-3963

amina-deriv closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

amina-deriv amina-deriv left review comments

hirad-deriv Awaiting requested review from hirad-deriv hirad-deriv is a code owner

matin-deriv Awaiting requested review from matin-deriv matin-deriv is a code owner

maryia-deriv Awaiting requested review from maryia-deriv

Labels

None yet