Skip to content

Commit

Permalink
unskip some more tests (#40221)
Browse files Browse the repository at this point in the history
this was fixed in #40218
  • Loading branch information
erwinmombay authored Jan 8, 2025
1 parent 87bb0ef commit d679610
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
3 changes: 1 addition & 2 deletions extensions/amp-lightbox/0.1/test/test-amp-lightbox.js
Original file line number Diff line number Diff line change
Expand Up @@ -105,8 +105,7 @@ describes.realWin(
});
});

// TODO(#40214): fix flaky test.
it.skip('should close on close-watcher signal', async () => {
it('should close on close-watcher signal', async () => {
const lightbox = createLightbox();
const impl = await lightbox.getImpl(true);

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -107,8 +107,7 @@ describes.fakeWin(
resolver.resolveUnknownAnchors(anchorList);
});

// TODO(#40214): fix flaky test.
it.skip('Should only ask for new domains the next times', () => {
it('Should only ask for new domains the next times', () => {
// Set the domains like if we had already done a call to the API.
resolver.domains_ = alreadyResolvedDomains;

Expand Down

0 comments on commit d679610

Please sign in to comment.