Connatix bugfixing #39696
Connatix bugfixing #39696
Conversation
cristisilav
commented
Dec 14, 2023
cristisilav
commented
- fix mute/unmute controls in the docking interface
- send dock/undock events to the iframe
|
Hey @alanorozco! These files were changed: |
erwinmombay
requested review from
erwinmombay and
powerivq
and removed request for
dmanek
|
@cristisilav im trying to reproduce the bug in the examples. would you mind giving me a step by step guide on how to reproduce the bug. I'm a little hesitant if the mutation observer approach here is the way to go do observe docking. trying to see if there is a low level event that we can programmatically listen to instead cc @powerivq |
|
also a heads up that we are currently in code freeze and will exit out of the freeze first week of January |
Regarding the bug, the issue was that the mute/unmute control in the docking interface would not always reflect the actual volume of the player, which happened because I didn't explicitly emit that mutedOrUnmutedEvent. |
| } | ||
| }; | ||
|
|
||
| const observer = new MutationObserver(callback); |
There was a problem hiding this comment.
Can you move the observer to a member property. When the player is being destroyed, we can clean up the observer.
|
@cristisilav I talked with @powerivq and we couldn't find a low level event to listen to, so lets go ahead and proceed with this change with the minor request that @powerivq asked for and we can merge this |
|
@cristisilav could you rebase from main to fetch the latest updates. i think that should fix the circle ci/test failure |
* various fixes * minor change (cherry picked from commit 394ee4b)
* various fixes * minor change
