Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick fix to the interval/timeout namespace conflict #40238

Merged
merged 1 commit into from
Feb 3, 2025
Merged

Quick fix to the interval/timeout namespace conflict #40238

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion 3p/environment.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,11 @@ export function setInViewportForTesting(inV) {
// Active intervals. Must be global, because people clear intervals
// with clearInterval from a different window.
const intervals = {};
let intervalId = 1;

// TODO(40235): This is so we avoid the ID range of setTimeout. We
// should also patch setTimeout and clearTimeout to avoid having to
// use this.
let intervalId = 10000000;
erwinmombay marked this conversation as resolved.
Show resolved Hide resolved

/**
* Add instrumentation to a window and all child iframes.
Expand Down
Loading