Allow chapter editors to edit references.

amyjko · Mar 3, 2024 · 0a53feb · 0a53feb
1 parent 4adfb52
commit 0a53feb
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -5,6 +5,7 @@
 ## Enhancement
 
 -   Added link to link editor in the toolbar to simplify link testing.
+-   Allow chapter editors to edit references.
 
 ## Fixed
 

diff --git a/firestore.rules b/firestore.rules
@@ -24,7 +24,7 @@ service cloud.firestore {
         }
 
         function editionIsEditable(editionDoc) {
-          return request.auth != null && request.auth.uid in editionDoc.uids || bookIsEditable(getBook())
+          return request.auth != null && (request.auth.uid in editionDoc.uids || bookIsEditable(getBook()))
         }
 
         // Editions can be read if they are published or the user has permissions to edit the edition or book.

diff --git a/src/lib/components/page/Contexts.ts b/src/lib/components/page/Contexts.ts
@@ -107,7 +107,9 @@ export function isEditionEditable(): boolean {
         book !== undefined &&
         auth !== undefined &&
         auth.user !== null &&
-        (edition.isEditor(auth.user.uid) || book.isEditor(auth.user.uid))
+        (edition.isEditor(auth.user.uid) ||
+            book.isEditor(auth.user.uid) ||
+            edition.isChapterEditor(auth.user.uid))
     );
 }