Skip to content

Commit

Permalink
refactor(PeriphDrivers): Mark some HPB parameters as const
Browse files Browse the repository at this point in the history
To support the upcoming Zephyr HPB driver work, mark some
HPB functions parameters as const, where appropriate.

Signed-off-by: Pete Johanson <[email protected]>
  • Loading branch information
petejohanson-adi committed Mar 7, 2025
1 parent 2ec3f4e commit 54663b6
Show file tree
Hide file tree
Showing 6 changed files with 30 additions and 22 deletions.
8 changes: 5 additions & 3 deletions Libraries/PeriphDrivers/Include/MAX32650/hpb.h
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ typedef struct {
mxc_hpb_device_t device_type;

/** Pointer to array of address offset/value pairs */
mxc_hpb_cfg_reg_val_t *cfg_reg_val;
const mxc_hpb_cfg_reg_val_t *cfg_reg_val;

/** number of configuration pairs */
unsigned int cfg_reg_val_len;
Expand Down Expand Up @@ -174,7 +174,8 @@ void MXC_HPB_RegRead8(mxc_hpb_cfg_reg_val_t *cfg_reg_val, uint32_t base_addr, un
* @param base_addr Base address
* @param index 0 or 1 to determine which configuration settings
*/
void MXC_HPB_RegWrite8(mxc_hpb_cfg_reg_val_t *cfg_reg_val, uint32_t base_addr, unsigned int index);
void MXC_HPB_RegWrite8(const mxc_hpb_cfg_reg_val_t *cfg_reg_val, uint32_t base_addr,
unsigned int index);

/**
* @brief Read a variable
Expand All @@ -190,7 +191,8 @@ void MXC_HPB_RegRead16(mxc_hpb_cfg_reg_val_t *cfg_reg_val, uint32_t base_addr, u
* @param base_addr Base address
* @param index 0 or 1 to determine which configuration settings
*/
void MXC_HPB_RegWrite16(mxc_hpb_cfg_reg_val_t *cfg_reg_val, uint32_t base_addr, unsigned int index);
void MXC_HPB_RegWrite16(const mxc_hpb_cfg_reg_val_t *cfg_reg_val, uint32_t base_addr,
unsigned int index);

/**
* @brief Configure the HyperBus peripheral.
Expand Down
10 changes: 6 additions & 4 deletions Libraries/PeriphDrivers/Include/MAX32690/hpb.h
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ typedef struct {
mxc_hpb_device_t device_type;

/** Pointer to array of address offset/value pairs */
mxc_hpb_cfg_reg_val_t *cfg_reg_val;
const mxc_hpb_cfg_reg_val_t *cfg_reg_val;

/** number of configuration pairs */
unsigned int cfg_reg_val_len;
Expand Down Expand Up @@ -174,7 +174,8 @@ void MXC_HPB_RegRead8(mxc_hpb_cfg_reg_val_t *cfg_reg_val, uint32_t base_addr, un
* @param base_addr Base address
* @param index 0 or 1 to determine which configuration settings
*/
void MXC_HPB_RegWrite8(mxc_hpb_cfg_reg_val_t *cfg_reg_val, uint32_t base_addr, unsigned int index);
void MXC_HPB_RegWrite8(const mxc_hpb_cfg_reg_val_t *cfg_reg_val, uint32_t base_addr,
unsigned int index);

/**
* @brief Read a variable
Expand All @@ -190,7 +191,8 @@ void MXC_HPB_RegRead16(mxc_hpb_cfg_reg_val_t *cfg_reg_val, uint32_t base_addr, u
* @param base_addr Base address
* @param index 0 or 1 to determine which configuration settings
*/
void MXC_HPB_RegWrite16(mxc_hpb_cfg_reg_val_t *cfg_reg_val, uint32_t base_addr, unsigned int index);
void MXC_HPB_RegWrite16(const mxc_hpb_cfg_reg_val_t *cfg_reg_val, uint32_t base_addr,
unsigned int index);

/**
* @brief Configure the HyperBus peripheral.
Expand All @@ -200,7 +202,7 @@ void MXC_HPB_RegWrite16(mxc_hpb_cfg_reg_val_t *cfg_reg_val, uint32_t base_addr,
* this memory not used)
* @return #E_BAD_PARAM if configuration error, #E_NO_ERROR otherwise
*/
int MXC_HPB_Init(mxc_hpb_mem_config_t *mem0, mxc_hpb_mem_config_t *mem1);
int MXC_HPB_Init(const mxc_hpb_mem_config_t *mem0, const mxc_hpb_mem_config_t *mem1);

/**
* @brief Returns the contents of the status register.
Expand Down
8 changes: 5 additions & 3 deletions Libraries/PeriphDrivers/Source/HPB/hpb_me10.c
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,8 @@ void MXC_HPB_RegRead8(mxc_hpb_cfg_reg_val_t *cfg_reg_val, uint32_t base_addr, un
}

/* ************************************************************************** */
void MXC_HPB_RegWrite8(mxc_hpb_cfg_reg_val_t *cfg_reg_val, uint32_t base_addr, unsigned int index)
void MXC_HPB_RegWrite8(const mxc_hpb_cfg_reg_val_t *cfg_reg_val, uint32_t base_addr,
unsigned int index)
{
MXC_HPB_RevA_RegWrite8((mxc_hpb_reva_regs_t *)MXC_HPB, cfg_reg_val, base_addr, index);
}
Expand All @@ -53,13 +54,14 @@ void MXC_HPB_RegRead16(mxc_hpb_cfg_reg_val_t *cfg_reg_val, uint32_t base_addr, u
}

/* ************************************************************************** */
void MXC_HPB_RegWrite16(mxc_hpb_cfg_reg_val_t *cfg_reg_val, uint32_t base_addr, unsigned int index)
void MXC_HPB_RegWrite16(const mxc_hpb_cfg_reg_val_t *cfg_reg_val, uint32_t base_addr,
unsigned int index)
{
MXC_HPB_RevA_RegWrite16((mxc_hpb_reva_regs_t *)MXC_HPB, cfg_reg_val, base_addr, index);
}

/* ************************************************************************** */
int MXC_HPB_Init(mxc_hpb_mem_config_t *mem0, mxc_hpb_mem_config_t *mem1)
int MXC_HPB_Init(const mxc_hpb_mem_config_t *mem0, const mxc_hpb_mem_config_t *mem1)
{
/* Enable HyperBus Clocks */
MXC_SYS_ClockEnable(MXC_SYS_PERIPH_CLOCK_HBC);
Expand Down
8 changes: 5 additions & 3 deletions Libraries/PeriphDrivers/Source/HPB/hpb_me18.c
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,8 @@ void MXC_HPB_RegRead8(mxc_hpb_cfg_reg_val_t *cfg_reg_val, uint32_t base_addr, un
}

/* ************************************************************************** */
void MXC_HPB_RegWrite8(mxc_hpb_cfg_reg_val_t *cfg_reg_val, uint32_t base_addr, unsigned int index)
void MXC_HPB_RegWrite8(const mxc_hpb_cfg_reg_val_t *cfg_reg_val, uint32_t base_addr,
unsigned int index)
{
MXC_HPB_RevA_RegWrite8((mxc_hpb_reva_regs_t *)MXC_HPB, cfg_reg_val, base_addr, index);
}
Expand All @@ -53,13 +54,14 @@ void MXC_HPB_RegRead16(mxc_hpb_cfg_reg_val_t *cfg_reg_val, uint32_t base_addr, u
}

/* ************************************************************************** */
void MXC_HPB_RegWrite16(mxc_hpb_cfg_reg_val_t *cfg_reg_val, uint32_t base_addr, unsigned int index)
void MXC_HPB_RegWrite16(const mxc_hpb_cfg_reg_val_t *cfg_reg_val, uint32_t base_addr,
unsigned int index)
{
MXC_HPB_RevA_RegWrite16((mxc_hpb_reva_regs_t *)MXC_HPB, cfg_reg_val, base_addr, index);
}

/* ************************************************************************** */
int MXC_HPB_Init(mxc_hpb_mem_config_t *mem0, mxc_hpb_mem_config_t *mem1)
int MXC_HPB_Init(const mxc_hpb_mem_config_t *mem0, const mxc_hpb_mem_config_t *mem1)
{
/* Enable HyperBus Clocks */
MXC_SYS_ClockEnable(MXC_SYS_PERIPH_CLOCK_HPB);
Expand Down
10 changes: 5 additions & 5 deletions Libraries/PeriphDrivers/Source/HPB/hpb_reva.c
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
/* **** Functions **** */

/* ************************************************************************** */
static void MXC_HPB_RevA_ConfigMem(mxc_hpb_reva_regs_t *hpb, mxc_hpb_mem_config_t *mem,
static void MXC_HPB_RevA_ConfigMem(mxc_hpb_reva_regs_t *hpb, const mxc_hpb_mem_config_t *mem,
unsigned index)
{
int i;
Expand Down Expand Up @@ -81,7 +81,7 @@ void MXC_HPB_RevA_RegRead8(mxc_hpb_reva_regs_t *hpb, mxc_hpb_cfg_reg_val_t *cfg_
}

/* ************************************************************************** */
void MXC_HPB_RevA_RegWrite8(mxc_hpb_reva_regs_t *hpb, mxc_hpb_cfg_reg_val_t *cfg_reg_val,
void MXC_HPB_RevA_RegWrite8(mxc_hpb_reva_regs_t *hpb, const mxc_hpb_cfg_reg_val_t *cfg_reg_val,
uint32_t base_addr, unsigned int index)
{
if (!hpb || !cfg_reg_val || index > 1) {
Expand Down Expand Up @@ -111,7 +111,7 @@ void MXC_HPB_RevA_RegRead16(mxc_hpb_reva_regs_t *hpb, mxc_hpb_cfg_reg_val_t *cfg
}

/* ************************************************************************** */
void MXC_HPB_RevA_RegWrite16(mxc_hpb_reva_regs_t *hpb, mxc_hpb_cfg_reg_val_t *cfg_reg_val,
void MXC_HPB_RevA_RegWrite16(mxc_hpb_reva_regs_t *hpb, const mxc_hpb_cfg_reg_val_t *cfg_reg_val,
uint32_t base_addr, unsigned int index)
{
if (!hpb || !cfg_reg_val || index > 1) {
Expand All @@ -126,8 +126,8 @@ void MXC_HPB_RevA_RegWrite16(mxc_hpb_reva_regs_t *hpb, mxc_hpb_cfg_reg_val_t *cf
}

/* ************************************************************************** */
int MXC_HPB_RevA_Init(mxc_hpb_reva_regs_t *hpb, mxc_hpb_mem_config_t *mem0,
mxc_hpb_mem_config_t *mem1)
int MXC_HPB_RevA_Init(mxc_hpb_reva_regs_t *hpb, const mxc_hpb_mem_config_t *mem0,
const mxc_hpb_mem_config_t *mem1)
{
if (mem0) {
MXC_HPB_RevA_ConfigMem(hpb, mem0, 0);
Expand Down
8 changes: 4 additions & 4 deletions Libraries/PeriphDrivers/Source/HPB/hpb_reva.h
Original file line number Diff line number Diff line change
Expand Up @@ -46,14 +46,14 @@ typedef enum {
/* **** Function Prototypes **** */
void MXC_HPB_RevA_RegRead8(mxc_hpb_reva_regs_t *hpb, mxc_hpb_cfg_reg_val_t *cfg_reg_val,
uint32_t base_addr, unsigned int index);
void MXC_HPB_RevA_RegWrite8(mxc_hpb_reva_regs_t *hpb, mxc_hpb_cfg_reg_val_t *cfg_reg_val,
void MXC_HPB_RevA_RegWrite8(mxc_hpb_reva_regs_t *hpb, const mxc_hpb_cfg_reg_val_t *cfg_reg_val,
uint32_t base_addr, unsigned int index);
void MXC_HPB_RevA_RegRead16(mxc_hpb_reva_regs_t *hpb, mxc_hpb_cfg_reg_val_t *cfg_reg_val,
uint32_t base_addr, unsigned int index);
void MXC_HPB_RevA_RegWrite16(mxc_hpb_reva_regs_t *hpb, mxc_hpb_cfg_reg_val_t *cfg_reg_val,
void MXC_HPB_RevA_RegWrite16(mxc_hpb_reva_regs_t *hpb, const mxc_hpb_cfg_reg_val_t *cfg_reg_val,
uint32_t base_addr, unsigned int index);
int MXC_HPB_RevA_Init(mxc_hpb_reva_regs_t *hpb, mxc_hpb_mem_config_t *mem0,
mxc_hpb_mem_config_t *mem1);
int MXC_HPB_RevA_Init(mxc_hpb_reva_regs_t *hpb, const mxc_hpb_mem_config_t *mem0,
const mxc_hpb_mem_config_t *mem1);
uint32_t MXC_HPB_RevA_GetStatus(mxc_hpb_reva_regs_t *hpb);
void MXC_HPB_RevA_EnableInt(mxc_hpb_reva_regs_t *hpb, unsigned polarity);
unsigned MXC_HPB_RevA_GetFlag(mxc_hpb_reva_regs_t *hpb);
Expand Down

0 comments on commit 54663b6

Please sign in to comment.