-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(Boards,CMSIS,PeriphDrivers): Add fixes and features for MAX32572 to prep for release #890
Conversation
… RISCV applications since it was undefined.
…C. Removed GPIO2 and GPIO3.
…ded OTP in max32572.h.
…y files for ME55.
…oved GPIO2/GPIO3 from GCR registers.
…rors for RISCV applications since it was undefined." This reverts commit 176fe65.
…CTRL.chkres1 to bit 11.
…ield position and width.
/clang-format-run |
/clang-format-run |
/clang-format-run |
#define MXC_BASE_INTR ((uint32_t)0xE5070000UL) | ||
//#define MXC_BASE_INTR ((uint32_t)0xE5000000UL) | ||
/* For MCUs with extra RISCV core (RISCV1) */ | ||
#ifdef __riscv1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where does __riscv1
get defined?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't relevant for the ME55 but will be for the ME13B, so there are no __riscv1
references yet. This is preparation for ME13B since the ME55 is a subset of ME13B. Should I hold off on this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, yeah we might want to hold off until the system for the dual RISC-V cores is a little more fleshed out. We should be able to check against a generic RISC-V compilation as well as a specific core. So we may want to rename this to something like __core_riscv1
and define the base one as __core_riscv0
. Right now our RISCV_CORE
build option is just a toggle switch, but I can see it becoming a selector for the ME13B.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Up to you. I'm fine either way since it's unused
Description
This PR syncs up the changes from the
dev/me13b_me55-examples
branch to the latest design changes of the MAX32572Checklist Before Requesting Review