Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(Boards,CMSIS,PeriphDrivers): Add fixes and features for MAX32572 to prep for release #890

Merged
merged 269 commits into from
Jan 26, 2024

Conversation

sihyung-maxim
Copy link
Contributor

Description

This PR syncs up the changes from the dev/me13b_me55-examples branch to the latest design changes of the MAX32572

Checklist Before Requesting Review

  • PR Title follows correct guidelines.
  • Description of changes and all other relevant information.
  • (Optional) Link any related GitHub issues using a keyword
  • (Optional) Provide info on any relevant functional testing/validation. For API changes or significant features, this is not optional.

sihyung-maxim and others added 30 commits August 8, 2022 15:58
…rors for RISCV applications since it was undefined."

This reverts commit 176fe65.
@sihyung-maxim
Copy link
Contributor Author

/clang-format-run

@github-actions github-actions bot added the Workflow Related to Workflow development label Jan 24, 2024
@sihyung-maxim
Copy link
Contributor Author

/clang-format-run

@sihyung-maxim sihyung-maxim removed the WIP work in progress label Jan 24, 2024
@sihyung-maxim
Copy link
Contributor Author

/clang-format-run

@sihyung-maxim sihyung-maxim changed the title chore(Boards,CMSIS,PeriphDrivers): Add final fixes for MAX32572 before release chore(Boards,CMSIS,PeriphDrivers): Add fixes and features for MAX32572 to prep for release Jan 24, 2024
@github-actions github-actions bot added the Tools This issue or pull request involves a change to the Tools label Jan 26, 2024
#define MXC_BASE_INTR ((uint32_t)0xE5070000UL)
//#define MXC_BASE_INTR ((uint32_t)0xE5000000UL)
/* For MCUs with extra RISCV core (RISCV1) */
#ifdef __riscv1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where does __riscv1 get defined?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't relevant for the ME55 but will be for the ME13B, so there are no __riscv1 references yet. This is preparation for ME13B since the ME55 is a subset of ME13B. Should I hold off on this change?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, yeah we might want to hold off until the system for the dual RISC-V cores is a little more fleshed out. We should be able to check against a generic RISC-V compilation as well as a specific core. So we may want to rename this to something like __core_riscv1 and define the base one as __core_riscv0. Right now our RISCV_CORE build option is just a toggle switch, but I can see it becoming a selector for the ME13B.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Up to you. I'm fine either way since it's unused

@sihyung-maxim sihyung-maxim merged commit 8a79a2d into main Jan 26, 2024
9 checks passed
@sihyung-maxim sihyung-maxim deleted the dev/me55-release branch January 26, 2024 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MAX32520 Related to the MAX32520 (ES17) MAX32572 Related to the MAX32572 (ME55) Register Change This issue or pull request involves a change to the MSDK registers. Tools This issue or pull request involves a change to the Tools Workflow Related to Workflow development
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants