Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

163519119 comment track edit history #24

Open
wants to merge 70 commits into
base: develop
Choose a base branch
from

Conversation

NkFab
Copy link
Contributor

@NkFab NkFab commented May 3, 2019

What does this PR do?

Have comment track comment history.

Description of Task to be completed?

When a logged-in user edits a comment, it should show that the comment was edited and be able to see the original comment.

How should this be manually tested?

  • Clone the repo
  • npm install or yarn to install dependencies
  • npm run start or yarn start to start the app
  • View an article and add a comment
  • Edit the comment by clicking the edit icon on the right top corner.

Any background context you want to provide?

What are the relevant pivotal tracker stories?

#163519119

Screenshots (if appropriate)

image

Questions:

- add comment reducer
- add comment action
- add comment component
- add commentRender component
[starts #163519104]
- add more test
[finishes #163519104]
@NkFab NkFab force-pushed the ft-comment-track-edit-163519119 branch from b1e0020 to 6d9a165 Compare May 6, 2019 09:03
@NkFab NkFab marked this pull request as ready for review May 6, 2019 13:33
@NkFab NkFab force-pushed the ft-comment-track-edit-163519119 branch from 36f7522 to 1056fa4 Compare May 6, 2019 14:16
@NkFab NkFab requested review from Nziranziza, mcaleb808 and filschristian and removed request for Nziranziza May 6, 2019 14:26
@NkFab NkFab force-pushed the ft-comment-track-edit-163519119 branch from 1056fa4 to aa7b547 Compare May 6, 2019 14:31
@NkFab NkFab added ready to be merged No conflict and removed Work in progress labels May 6, 2019
Copy link
Contributor

@filschristian filschristian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please work on the comments.
Please change the title of this PR

@NkFab NkFab force-pushed the ft-comment-track-edit-163519119 branch from aa7b547 to 0780b52 Compare May 7, 2019 10:38
@NkFab NkFab changed the title Ft comment track edit 163519119 163519119 comment track edit history May 7, 2019
kimotho-njoki and others added 3 commits May 8, 2019 18:02

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
#163519109  share article social
- add comment reducer
- add comment action
- add comment component
- add commentRender component
[starts #163519104]
- add more test
[finishes #163519104]
@NkFab NkFab requested a review from filschristian May 11, 2019 14:26

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
#163519120 Add like and dislike a comment
kimotho-njoki and others added 23 commits May 13, 2019 19:16

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
#163519111 Add Notifications
- add tests
- add Home Components
- add Home page functionalities
- add Landing page functionalities

[finishes 165571064]

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
#165571064 Add landing and home pages
- add comment reducer
- add comment action
- add comment component
- add commentRender component
[starts #163519104]
- add more test
[finishes #163519104]
…it-Kigali1-Frontend into ft-comment-track-edit-163519119
…it-Kigali1-Frontend into ft-comment-track-edit-163519119
…it-Kigali1-Frontend into ft-comment-track-edit-163519119
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants