-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
163519119 comment track edit history #24
Open
NkFab
wants to merge
70
commits into
develop
Choose a base branch
from
ft-comment-track-edit-163519119
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+4,380
−575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add comment reducer - add comment action - add comment component - add commentRender component [starts #163519104]
- add more test [finishes #163519104]
b1e0020
to
6d9a165
Compare
36f7522
to
1056fa4
Compare
1056fa4
to
aa7b547
Compare
filschristian
suggested changes
May 6, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please work on the comments.
Please change the title of this PR
- add comment reducer - add comment action - add comment component - add commentRender component [starts #163519104]
- add more test [finishes #163519104]
aa7b547
to
0780b52
Compare
#163519109 share article social
- add comment reducer - add comment action - add comment component - add commentRender component [starts #163519104]
- add more test [finishes #163519104]
#163519120 Add like and dislike a comment
#163519111 Add Notifications
- add tests - add Home Components - add Home page functionalities - add Landing page functionalities [finishes 165571064]
#165571064 Add landing and home pages
- add comment reducer - add comment action - add comment component - add commentRender component [starts #163519104]
- add more test [finishes #163519104]
…it-Kigali1-Frontend into ft-comment-track-edit-163519119
…it-Kigali1-Frontend into ft-comment-track-edit-163519119
…it-Kigali1-Frontend into ft-comment-track-edit-163519119
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Have comment track comment history.
Description of Task to be completed?
When a logged-in user edits a comment, it should show that the comment was edited and be able to see the original comment.
How should this be manually tested?
npm install
oryarn
to install dependenciesnpm run start
oryarn start
to start the appAny background context you want to provide?
What are the relevant pivotal tracker stories?
#163519119
Screenshots (if appropriate)
Questions: