Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add some missing members to Status entity #131

Merged
merged 3 commits into from
Jan 31, 2023

Conversation

bocops
Copy link
Collaborator

@bocops bocops commented Jan 31, 2023

This does not yet close 16, but at least adding the text field is necessary for #124, which is scheduled for 2.0.0

- adds: card, text, edited_at, muted, bookmarked - text is necessary for work on editing statuses (andregasser#124)

- does not add: poll, filtered - held up by andregasser#129 and andregasser#130, respectively

- renames Card to PreviewCard, according to Mastodon API
- adds: card, text, edited_at, muted, bookmarked - text is necessary for work on editing statuses (andregasser#124)

- does not add: poll, filtered - held up by andregasser#129 and andregasser#130, respectively

- renames Card to PreviewCard, according to Mastodon API
…_entity

# Conflicts:
#	bigbone-rx/src/main/kotlin/social/bigbone/rx/RxStatusMethods.kt
@codecov
Copy link

codecov bot commented Jan 31, 2023

Codecov Report

Merging #131 (e78891c) into master (18f7156) will increase coverage by 0.34%.
The diff coverage is 100.00%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #131      +/-   ##
============================================
+ Coverage     44.61%   44.95%   +0.34%     
  Complexity      169      169              
============================================
  Files            67       67              
  Lines          1439     1448       +9     
  Branches         83       83              
============================================
+ Hits            642      651       +9     
  Misses          775      775              
  Partials         22       22              
Impacted Files Coverage Δ
...c/main/kotlin/social/bigbone/rx/RxStatusMethods.kt 0.00% <ø> (ø)
.../kotlin/social/bigbone/api/method/StatusMethods.kt 85.71% <ø> (ø)
...in/kotlin/social/bigbone/api/entity/PreviewCard.kt 100.00% <100.00%> (ø)
...rc/main/kotlin/social/bigbone/api/entity/Status.kt 100.00% <100.00%> (ø)

@andregasser andregasser merged commit 54da208 into andregasser:master Jan 31, 2023
@bocops bocops deleted the 16_status_entity branch January 31, 2023 22:22
@bocops bocops mentioned this pull request Feb 6, 2023
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants