-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up endpoint definitions in methods classes #410
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #410 +/- ##
============================================
+ Coverage 49.25% 49.43% +0.18%
Complexity 714 714
============================================
Files 169 169
Lines 4769 4790 +21
Branches 312 312
============================================
+ Hits 2349 2368 +19
- Misses 2157 2159 +2
Partials 263 263
|
bigbone/src/test/kotlin/social/bigbone/api/method/DomainBlockMethodsTest.kt
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the cleanup 👍 . I had only one comment regarding test classes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good.
Description
In this PR, I cleaned up how we refer to endpoints:
api/v1/…
, not/api/v1/…
)val
are namedendpoint
(orendpointV1
andendpointV2
if we have multiple) so that all method classes follow mostly the same structureval
sRelates to #396
Type of Change
Breaking Changes
How Has This Been Tested?
I ran existing unit tests through
gradle check
Mandatory Checklist
gradle check
and there were no errors reported