-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wip] Darude mods #1
Open
liamzebedee
wants to merge
5
commits into
andrewmilson:main
Choose a base branch
from
liamzebedee:mods
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
# read the file in array-sum.proof and write it in hex to the file array-sum.proof.hex | ||
# this is the file that is used by the verifier | ||
|
||
import sys | ||
import binascii | ||
|
||
|
||
data = open(sys.argv[1], 'r').read() | ||
# decode data from hex into binary string | ||
data = binascii.unhexlify(data) | ||
open(sys.argv[2], 'wb').write(data) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
set -ex | ||
|
||
python2 binary.py memory.bin memory.bin.hex | ||
python2 binary.py trace.bin trace.bin.hex | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
# read the file in array-sum.proof and write it in hex to the file array-sum.proof.hex | ||
# this is the file that is used by the verifier | ||
|
||
import sys | ||
|
||
data = open(sys.argv[1], 'rb').read() | ||
open(sys.argv[2], 'wb').write(data.encode('hex')) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
cargo +nightly run -r -F asm -- \ | ||
verify --program array-sum.json \ | ||
--proof proof.local.bin |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,7 +2,6 @@ use ark_serialize::CanonicalDeserialize; | |
use ark_serialize::CanonicalSerialize; | ||
// use more performant global allocator | ||
#[cfg(not(target_env = "msvc"))] | ||
use jemallocator::Jemalloc; | ||
use ministark::Proof; | ||
use ministark::ProofOptions; | ||
use ministark::Prover; | ||
|
@@ -20,10 +19,6 @@ use std::path::PathBuf; | |
use std::time::Instant; | ||
use structopt::StructOpt; | ||
|
||
#[cfg(not(target_env = "msvc"))] | ||
#[global_allocator] | ||
static GLOBAL: Jemalloc = Jemalloc; | ||
|
||
Comment on lines
-23
to
-26
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👍 |
||
#[derive(StructOpt, Debug)] | ||
#[structopt(name = "sandstorm", about = "cairo prover")] | ||
enum SandstormOptions { | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The types already implement deref. Is there a need to make this public?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again I should've said WIP. Short-term fix to get this working:
https://github.com/ponderingdemocritus/darude/blob/main/wasm/src/lib.rs#L172-L183
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IDK how to use deref to solve it, so just publicised it for now (we don't have to merge it in).