Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to load notebooks from URL or from local file #12

Open
wants to merge 1 commit into
base: gh-pages
Choose a base branch
from

Conversation

louisabraham
Copy link

@louisabraham louisabraham commented Sep 3, 2017

You can test locally with:

jekyll serve --baseurl='/iocamljs'

@louisabraham
Copy link
Author

My modifications might trigger problems:
- the original code is made to work with a notebook_id and not an URL or a file
- I call load_notebook_success so this.start_kernel();, maybe there is a memory leak, maybe there should be a boolean to call restart_kernel instead
- IPython.Kernel.start takes a notebook_id argument.

@louisabraham
Copy link
Author

Hi, did you look at this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant