Add Restore Credential Support for Shrine app #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I476116b1f3400c452783d2f172bd7adbca5fcadb
Shrine/app/src/main/java/com/example/android/authentication/shrine/CredentialManagerUtils.kt
Show resolved
Hide resolved
Shrine/app/src/main/java/com/example/android/authentication/shrine/CredentialManagerUtils.kt
Show resolved
Hide resolved
Shrine/app/src/main/java/com/example/android/authentication/shrine/CredentialManagerUtils.kt
Show resolved
Hide resolved
Shrine/app/src/main/java/com/example/android/authentication/shrine/ui/RegisterScreen.kt
Show resolved
Hide resolved
danjkim
reviewed
Nov 18, 2024
Shrine/app/src/main/java/com/example/android/authentication/shrine/CredentialManagerUtils.kt
Show resolved
Hide resolved
danjkim
reviewed
Nov 18, 2024
Shrine/app/src/main/java/com/example/android/authentication/shrine/CredentialManagerUtils.kt
Show resolved
Hide resolved
Shrine/app/src/main/java/com/example/android/authentication/shrine/CredentialManagerUtils.kt
Show resolved
Hide resolved
niharika2810
requested changes
Feb 10, 2025
| restoreCredentialRequest, | ||
| ) | ||
| } catch (e: Exception) { | ||
| e.printStackTrace() |
| @@ -17,16 +17,19 @@ package com.example.android.authentication.shrine | |||
|
|
|||
| import android.annotation.SuppressLint | |||
| import android.content.Context | |||
| import androidx.credentials.ClearCredentialStateRequest | |||
There was a problem hiding this comment.
@neelanshsahai can we update the README to tell about RestoreCredentials functionality? @cy245 FYI
| context: Context, | ||
| ) { | ||
| val passkeysEligibility = PasskeysEligibility.isPasskeySupported(context) | ||
| if (passkeysEligibility.isEligible) { |
There was a problem hiding this comment.
if not eligible, are we throwing any error?
|
|
||
| suspend fun getRestoreKey( | ||
| authenticationJson: JSONObject, | ||
| activity: Context, |
There was a problem hiding this comment.
keep either activ ity or context which is more reasonable?
| creationResult = jsonObject, | ||
| ) | ||
| } | ||
| getPasskey = { jsonObject -> |
There was a problem hiding this comment.
is it getPasskeyRequest or reponse or just a result, a bit confusing? Can we name accordingly?
| context = activityContext, | ||
| ) | ||
| } | ||
| createPassword = { username: String, password: String -> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-Id: I476116b1f3400c452783d2f172bd7adbca5fcadb