Fixed EINVAL error with fs.utimesSync() due to incorrect Unix timestamp #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per the node.js documentation for `fs.utimes`: > The value should be a Unix timestamp in seconds. For example, > `Date.now()` returns milliseconds, so it should be divided by 1000 > before passing it in. I'm not sure why this wasn't causing a problem for most people, but it was reported by @mseminatore as a problem on Windows, on node.js v0.12.2. In any case, this fix doesn't cause a problem on Linux, on node.js v6.9.1, so I'm happy to make the fix.
- Added myself. - Added @delwyn, who had made a contribution earlier. - Added @mseminatore, who contributed recently.
For now. Will add it back as a separate commit, because it is causing tests to break.
aneilbaboo
pushed a commit
that referenced
this pull request
Dec 14, 2017
…de-issue When options is already a string, don't parse it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add @mseminatore's fix from the sepia project.
Fixes LinkedInAttic/sepia#19
Fixes LinkedInAttic/sepia#17