Track current Sarus state in state machine #404
Conversation
Add a new class property `state` that stores the current state of a Sarus object. This allows us to cleanly determine whether a Sarus object has ever connected, whether a connection is failing, whether a user has disconnected a Sarus object, and so on.
This doesn't do anything for now, it's always "created"
Sarus will try to connect automatically in the constructor, so it is not necessary to distinguish between "created" and "connecting".
justuswilhelm
force-pushed
the
state-machine
branch
from
408bc26 to
9578a8b
Compare
| sarus.connect(); | ||
| expect(sarus.state).toBe("connecting"); | ||
| await server.connected; | ||
| // XXX for some reason the test will fail without waiting 10 ms here |
There was a problem hiding this comment.
There's a function in Hub's repo called delayUntil which will delay until a condition is met:
https://github.com/anephenix/hub/blob/master/helpers/delay.js
We could potentially import that function into the helpers/delay.ts file and use this code instead of delaying for 10 miliseconds:
delayUntil(() => sarus.state === "connected")There was a problem hiding this comment.
yes, it would be better to not have to hardcode a duration here. Unfortunately I do not understand the websocket mock well enough. It was my understanding that awaiting server.connected should already cover the required waiting. I don't see how awaiting any more than that is changing the sarus.state (e.g. onopen being called).
Some leaky abstraction perhaps? If you have any ideas, please let me know.
This pull request adds a new .state property to see whether Sarus is connecting right now, or if a connection has been closed or disconnected by the user. This way, we can easily keep track of failed connection attempts. This is useful for #403