Merge pull request #691 from aramirezj/fix/add-outputPath-param

fix(nativeFederation): fixes the missing behaviour of the param outputPath
angular-architects · Feb 15, 2025 · 0b27536 · 0b27536
2 parents ae03fba + 7fbf48b
commit 0b27536
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 1 deletion.
diff --git a/libs/native-federation/src/builders/build/builder.ts b/libs/native-federation/src/builders/build/builder.ts
@@ -122,6 +122,10 @@ export async function* runBuilder(
     options.baseHref = nfOptions.baseHref;
   }
 
+  if(nfOptions.outputPath){
+    options.outputPath = nfOptions.outputPath;
+  }
+
   const rebuildEvents = new RebuildHubs();
 
   const adapter = createAngularBuildAdapter(options, context, rebuildEvents);

diff --git a/libs/native-federation/src/builders/build/schema.d.ts b/libs/native-federation/src/builders/build/schema.d.ts
@@ -12,6 +12,7 @@ export interface NfBuilderSchema extends JsonObject {
   skipHtmlTransform: boolean;
   esmsInitOptions: ESMSInitOptions;
   baseHref?: string;
+  outputPath?: string;
   ssr: boolean;
   devServer?: boolean;
 } // eslint-disable-line
diff --git a/libs/native-federation/src/builders/build/schema.json b/libs/native-federation/src/builders/build/schema.json
@@ -46,6 +46,9 @@
     "baseHref": {
       "type": "string"
     },
+    "outputPath": {
+      "type": "string"
+    },
     "esmsInitOptions": {
       "type": "object",
       "description": "Options for esms-module-shims https://github.com/guybedford/es-module-shims?tab=readme-ov-file#init-options",

diff --git a/libs/native-federation/src/utils/angular-esbuild-adapter.ts b/libs/native-federation/src/utils/angular-esbuild-adapter.ts
@@ -279,7 +279,7 @@ async function runEsbuild(
     splitting: kind === 'mapping-or-exposed',
     platform: platform ?? 'browser',
     format: 'esm',
-    target: ['esnext'],
+    target: target,
     logLimit: kind === 'shared-package' ? 1 : 0,
     plugins: (plugins as any) || [
       createCompilerPlugin(