Skip to content

#58 Fix issue downloading large CSV files in Chrome #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

#58 Fix issue downloading large CSV files in Chrome #67

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
af32038
Fix network error on large CSV downloads in Chrome
elizabeth Oct 23, 2017
c3fdb80
Fix spacing
elizabeth Oct 23, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 16 additions & 24 deletions dist/JSONToCSVConvertor.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,34 +51,26 @@ function JSONToCSVConvertor(JSONData, ReportTitle, ShowLabel) {
//Generate a file name
var fileName = "";
//this will remove the blank-spaces from the title and replace it with an underscore
fileName += ReportTitle.replace(/ /g, "_");

fileName += ReportTitle.replace(/ /g, "_") + ".csv";
//Initialize file format you want csv or xls
var uri = 'data:text/csv;charset=utf-8,' + escape(CSV);

// Set UTF-8 formatting
var uri = "\uFEFF" + CSV;

// Now the little tricky part.
// you can use either>> window.open(uri);
// but this will not work in some browsers
// or you will not get the correct file extension

//this trick will generate a temp <a /> tag

if (navigator.msSaveBlob) {
uri = 'data:text/csv;charset=utf-8,' + CSV;
navigator.msSaveBlob(new Blob([uri], {type: 'text/csv;charset=utf-8;'}), fileName + ".csv");
}

else {
var link = document.createElement("a");
link.href = uri;

//set the visibility hidden so it will not effect on your web-layout
link.style = "visibility:hidden";
link.download = fileName + ".csv";

//this part will append the anchor tag and remove it after automatic click
document.body.appendChild(link);
link.click();
document.body.removeChild(link);
var blob = new Blob([uri], {type: 'text/csv;charset=utf-8;'});
if (navigator.msSaveOrOpenBlob) {
navigator.msSaveBlob(blob, fileName);
} else {
//this trick will generate a temp <a /> tag
var elem = window.document.createElement('a');
elem.href = window.URL.createObjectURL(blob);
elem.download = fileName;
document.body.appendChild(elem);
elem.click();
document.body.removeChild(elem);
}
}