refactor(@angular/cli): convert npm-package-arg usage from require to import
#21429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to import The typings package was already present for `npm-package-arg` and the removal of require usage supports the eventual shift to an ESM output for the CLI package.
clydin
commented
Jul 27, 2021
| @@ -235,6 +231,28 @@ export class AddCommand extends SchematicCommand<AddCommandSchema> { | |||
| return this.executeSchematic(collectionName, options['--']); | |||
| } | |||
|
|
|||
| private async isProjectVersionValid(packageIdentifier: npa.Result): Promise<boolean> { | |||
There was a problem hiding this comment.
This was refactored into a separate method to avoid the 200 line limit for the run method.
alan-agius4
approved these changes
Jul 27, 2021
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The typings package was already present for
npm-package-argand the removal of require usage supports the eventual shift to an ESM output for the CLI package.