Remove polyfills file #23938

alan-agius4 · 2022-09-21T08:54:40Z

feat(@angular-devkit/build-angular): amend polyfills option in all builders to support an array of module specifiers

This is the ground work to be able to remove the polyfills.ts file which today is primarily used to add zone.js.

Usage examples:

polyfills: ['zone.js'],

polyfills: ['zone.js', 'zone.js/testing', 'src/polyfills.ts'],

feat(@schematics/angular): drop polyfills.ts file from new templates

With this change we drop the polyfills.ts from new application projects and add the polyfills directly in the angular.json. This is possible as now the polyfills option accept an array of module specifiers.

This change also fixes another open issue (#14432) which was caused by the missing polyfills file in the library test setup.

Closes #14432

e-oz · 2022-09-22T07:01:09Z

Will it still be possible to define Zone.JS flags before importing Zone.JS?

alan-agius4 · 2022-09-22T14:03:09Z

Will it still be possible to define Zone.JS flags before importing Zone.JS?

You can still provide those in a polyfills.ts file.

e-oz · 2022-09-22T14:05:20Z

You can still provide those in a polyfills.ts file.

If I remember correctly, the order of imports matters here. Flags should be defined before zone.js import.

alan-agius4 · 2022-09-22T14:24:28Z

You can order the files to imports as you'd needed.

Example:

polyfills: ['./zone-flags.ts', 'zone.js'],
polyfills: ['./zone-flags.ts', 'zone.js', './other-polyfills.ts', ...],

e-oz · 2022-09-22T14:28:56Z

Thanks a lot for answering :)

packages/angular_devkit/build_angular/src/builders/browser-esbuild/schema.json

clydin · 2022-09-26T15:15:31Z

packages/angular_devkit/build_angular/src/builders/browser-esbuild/options.ts

-  const polyfillsEntryPoint = options.polyfills && path.join(workspaceRoot, options.polyfills);
+
+  // Currently esbuild do not support multiple files per entry-point
+  const [polyfillsEntryPoint, ...remainingPolyfills] = normalizePolyfills(


Can the path resolving step be skipped here? The absolute paths will end up in the sourcemaps.
esbuild should be able to resolve the relative paths directly.

As per off-line convo, lets do this in a follow up

…builders to support an array of module specifiers This is the ground work to be able to remove the `polyfills.ts` file which today is primarily used to add `zone.js`. Usage examples: ```js polyfills: ['zone.js'], polyfills: ['zone.js', 'zone.js/testing', 'src/polyfills.ts'], ```

With this change we drop the `polyfills.ts` from new application projects and add the polyfills directly in the `angular.json`. This is possible as now the `polyfills` option accept an array of module specifiers. This change also fixes another open issue (angular#14432) which was caused by the missing polyfills file in the library test setup. Closes angular#14432

ngbot · 2022-09-26T15:59:19Z

I see that you just added the action: merge label, but the following checks are still failing:
     status "ci/circleci: build-bazel-e2e" is failing
     status "ci/circleci: e2e-cli-npm" is pending
     status "ci/circleci: e2e-cli-win" is pending
If you want your PR to be merged, it has to pass all the CI checks.
If you can't get the PR to a green state due to flakes or broken main, please try rebasing to main and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

With the recent changes in the Angular CLI (angular/angular-cli#23938) the polyfills option accepts module path that are resolved using Node module resolution. Also, the polyfills.ts file is no longer generated by default. This commit changes the way on how the polyfill is added to the projects.

#47569) With the recent changes in the Angular CLI (angular/angular-cli#23938) the polyfills option accepts module path that are resolved using Node module resolution. Also, the polyfills.ts file is no longer generated by default. This commit changes the way on how the polyfill is added to the projects. PR Close #47569

angular#47569) With the recent changes in the Angular CLI (angular/angular-cli#23938) the polyfills option accepts module path that are resolved using Node module resolution. Also, the polyfills.ts file is no longer generated by default. This commit changes the way on how the polyfill is added to the projects. PR Close angular#47569

angular-automatic-lock-bot · 2022-10-27T08:03:33Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

alan-agius4 added the target: major This PR is targeted for the next major release label Sep 21, 2022

alan-agius4 force-pushed the polyfills-array branch 3 times, most recently from 70cdde2 to 4f20da4 Compare September 21, 2022 13:34

alan-agius4 force-pushed the polyfills-array branch from 4f20da4 to 03b7de3 Compare September 22, 2022 14:02

alan-agius4 force-pushed the polyfills-array branch from 03b7de3 to bfe4fde Compare September 22, 2022 14:04

alan-agius4 force-pushed the polyfills-array branch 2 times, most recently from bf3813e to f31a70e Compare September 22, 2022 14:28

alan-agius4 requested a review from clydin September 22, 2022 15:24

alan-agius4 added the action: review The PR is still awaiting reviews from at least one requested reviewer label Sep 22, 2022

alan-agius4 marked this pull request as ready for review September 22, 2022 15:41

alan-agius4 force-pushed the polyfills-array branch 2 times, most recently from 202c566 to dfeaba8 Compare September 22, 2022 15:50

alan-agius4 added this to the v15 Feature Freeze milestone Sep 22, 2022

alan-agius4 force-pushed the polyfills-array branch 7 times, most recently from ad23fb8 to e634ff7 Compare September 22, 2022 17:46

clydin requested changes Sep 26, 2022

View reviewed changes

alan-agius4 force-pushed the polyfills-array branch from 1504352 to 5341730 Compare September 26, 2022 15:46

angular-robot bot added the feature Issue that requests a new feature label Sep 26, 2022

alan-agius4 requested a review from clydin September 26, 2022 15:46

alan-agius4 force-pushed the polyfills-array branch from 5341730 to 1c80211 Compare September 26, 2022 15:47

clydin approved these changes Sep 26, 2022

View reviewed changes

alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Sep 26, 2022

alan-agius4 merged commit 597bfea into angular:main Sep 26, 2022

alan-agius4 deleted the polyfills-array branch September 26, 2022 16:27

alan-agius4 mentioned this pull request Sep 28, 2022

fix(localize): add polyfill in polyfills array instead of polyfills.ts angular/angular#47569

Closed

angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 27, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove polyfills file #23938

Remove polyfills file #23938

alan-agius4 commented Sep 21, 2022

e-oz commented Sep 22, 2022

alan-agius4 commented Sep 22, 2022

e-oz commented Sep 22, 2022

alan-agius4 commented Sep 22, 2022 •

edited

Loading

e-oz commented Sep 22, 2022

clydin Sep 26, 2022

alan-agius4 Sep 26, 2022

ngbot bot commented Sep 26, 2022

angular-automatic-lock-bot bot commented Oct 27, 2022

Remove polyfills file #23938

Remove polyfills file #23938

Conversation

alan-agius4 commented Sep 21, 2022

e-oz commented Sep 22, 2022

alan-agius4 commented Sep 22, 2022

e-oz commented Sep 22, 2022

alan-agius4 commented Sep 22, 2022 • edited Loading

e-oz commented Sep 22, 2022

clydin Sep 26, 2022

Choose a reason for hiding this comment

alan-agius4 Sep 26, 2022

Choose a reason for hiding this comment

ngbot bot commented Sep 26, 2022

angular-automatic-lock-bot bot commented Oct 27, 2022

alan-agius4 commented Sep 22, 2022 •

edited

Loading