This repository was archived by the owner on Dec 4, 2017. It is now read-only.
docs(toh-5): use Array.prototype.find() instead of filter
#1801
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are in TypeScript, so we cain avoid worrying about ECMAScript methods being implemented or not (as `find()` is already implemented in TypeScript) and, personally, my eyes hurt when I see a `filter()` returning its first element `[0]' without checking if it returned something before.
kutyel
changed the title
Array.prototype.find() instead of filterArray.prototype.find() instead of filter
wardbell
added a commit
to IdeaBlade/angular.io
that referenced
this pull request
Jul 2, 2016
|
I agree. And many thanks! But why stop with this file? Fix 'em all. That's what I did with #1816 which supersedes your PR here. |
|
Thanks @wardbell! I agree with you as well. Nevertheless, I really would have liked to make the change myself, to feel that I was doing my bit... 😉 |
|
Oh. Sorry. But you really did the most important thing by calling it out. The rest took me 15 minutes. Thanks again. |
|
Ok, don't worry! You're welcome! 😄 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are in TypeScript, so we can avoid worrying about ECMAScript methods being implemented or not (as
find()is already implemented in TypeScript) and, personally, my eyes hurt when I see afilter()returning its first element[0]without checking if it returned something before.