Skip to content
This repository was archived by the owner on Dec 4, 2017. It is now read-only.

docs: replace xxx.filter(...)[0] with xxx.find(...) #1816

Merged
merged 1 commit into from
Jul 2, 2016
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ export class HeroService {
];

getHeroById(id: number): Hero {
return this.heroes.filter(hero => hero.id === id)[0];
return this.heroes.find(hero => hero.id === id);
}

getAllHeroes(): Array<Hero> {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ export class CrisisService {

getCrisis(id: number | string) {
return crisesPromise
.then(crises => crises.filter(c => c.id === +id)[0]);
.then(crises => crises.find(c => c.id === +id));
}

// #enddocregion
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,6 @@ export class HeroService {

getHero(id: number | string) {
return heroesPromise
.then(heroes => heroes.filter(h => h.id === +id)[0]);
.then(heroes => heroes.find(h => h.id === +id));
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ export class CrisisService {

getCrisis(id: number | string) {
return crisesPromise
.then(crises => crises.filter(c => c.id === +id)[0]);
.then(crises => crises.find(crisis => crisis.id === +id));
}

// #enddocregion
Expand Down
2 changes: 1 addition & 1 deletion public/docs/_examples/router/ts/app/heroes/hero.service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,6 @@ export class HeroService {

getHero(id: number | string) {
return heroesPromise
.then(heroes => heroes.filter(h => h.id === +id)[0]);
.then(heroes => heroes.find(hero => hero.id === +id));
}
}
2 changes: 1 addition & 1 deletion public/docs/_examples/testing/ts/app/hero.service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ export class HeroService {
// #docregion get-hero
getHero(id: number) {
return Promise.resolve(HEROES).then(
heroes => heroes.filter(hero => hero.id === id)[0]
heroes => heroes.find(hero => hero.id === id)
);
}
// #enddocregion get-hero
Expand Down
2 changes: 1 addition & 1 deletion public/docs/_examples/toh-5/ts/app/hero.service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ export class HeroService {
// #docregion get-hero
getHero(id: number) {
return this.getHeroes()
.then(heroes => heroes.filter(hero => hero.id === id)[0]);
.then(heroes => heroes.find(hero => hero.id === id));
}
// #enddocregion get-hero
}
2 changes: 1 addition & 1 deletion public/docs/_examples/toh-6/ts/app/hero.service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ export class HeroService {

getHero(id: number) {
return this.getHeroes()
.then(heroes => heroes.filter(hero => hero.id === id)[0]);
.then(heroes => heroes.find(hero => hero.id === id));
}

// #docregion save
Expand Down