fix(material/table): Sorting of a string column/property breaks if one record contains a number only #23453
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e record contains a number only If the number is a string and in between strings we treat it as a number and group it at the start/end of the table based on it's ascending or descending. I have fixed the issue in my commit here and I think it will work properly. Fixes angular#20140
google-cla
bot
added
the
cla: yes
|
@andrewseguin thoughts? |
andrewseguin
removed
the
cla: yes
|
Can you create a test that demonstrates what this change is fixing and to prevent regressions |
andrewseguin
added
the
needs: clarification
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(material/table): Sorting of a string column/property breaks if one record contains a number only
If the number is a string and in between strings we treat it as a number and group it at the start/end of the table based on it's ascending or descending. I have fixed the issue in my commit here and I think it will work properly.
Fixes #20140