Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(material/slide-toggle): Increase slide-toggle transition time #29441

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

GiftLanga
Copy link
Contributor

Increases the animation transition time to 300ms

Fixes #28916

@GiftLanga GiftLanga requested a review from a team as a code owner July 16, 2024 14:16
@GiftLanga GiftLanga requested review from amysorto and mmalerba and removed request for a team July 16, 2024 14:16
@crisbeto crisbeto added the dev-app preview When applied, previews of the dev-app are deployed to Firebase label Jul 16, 2024
Copy link

github-actions bot commented Jul 16, 2024

Deployed dev-app for 24e9efa to: https://ng-dev-previews-comp--pr-angular-components-29441-dev-fxhoer4z.web.app

Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt.

@crisbeto
Copy link
Member

It might just be me, I'd be interested to hear others' opinion, but the animation still feels a bit harsh because some parts are instant. It's a bit more obvious when the animation is slowed down:

Screen.Recording.2024-07-16.at.18.50.26.mov

@mmalerba mmalerba requested review from crisbeto and removed request for mmalerba July 17, 2024 21:28
@GiftLanga
Copy link
Contributor Author

It might just be me, I'd be interested to hear others' opinion, but the animation still feels a bit harsh because some parts are instant. It's a bit more obvious when the animation is slowed down:

Screen.Recording.2024-07-16.at.18.50.26.mov

So I checked, It seems the tracks animation is at 75ms while the handle is at 300ms.
To sync them I have to change the variables in the _switch.scss file
image

Increases the animation transition time to 300ms

Fixes angular#28916
@crisbeto
Copy link
Member

It still looks to me like it's "flashing" any time the state is changed. Note in the slowed down recording how there's a point where it completely blends in with the background.

Screen.Recording.2024-07-24.at.11.10.16.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev-app preview When applied, previews of the dev-app are deployed to Firebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(material/slide-toggle): Animation duration in M3 should be 300ms
2 participants