fix(material/toolbar): Update icon button color to match label text color token #30280
Conversation
amysorto
requested review from
crisbeto and
mmalerba
and removed request for
a team
src/material/toolbar/toolbar.scss
Outdated
| @@ -56,6 +56,8 @@ $height-mobile-portrait: 56px !default; | |||
| @include token-utils.use-tokens( | |||
| tokens-mat-toolbar.$prefix, tokens-mat-toolbar.get-token-slots()) { | |||
| $color-token: token-utils.get-token-variable(container-text-color); | |||
| // Update icon button color to match label text color for consistency while overriding. | |||
| --mdc-icon-button-icon-color: $color-token; | |||
There was a problem hiding this comment.
We should do this through use-tokens, instead of hardcoding the name. See in the next few lines how it's done for the outlined and text buttons.
amysorto
force-pushed
the
toolbar-icon-color-overrides
branch
from
c0be42b to
1d35c12
Compare
|
@amysorto what is the status of this PR? it's not yet merged in the latest release :-( |
|
@crisbeto do you know why this PR is still open?It is a bit of a showstopper |
|
I just encountered the issue this PR fixes for toolbar icons when trying to adapt the M3 theme. Is this PR being blocked by something? I can't see this fix included in any existing versions.
|
mmalerba
force-pushed
the
toolbar-icon-color-overrides
branch
from
1d35c12 to
bf9e795
Compare
mmalerba
force-pushed
the
toolbar-icon-color-overrides
branch
from
bf9e795 to
7f28810
Compare
mmalerba
added
action: merge
|
There are hundreds of screenshots in g3 that wind up looking worse with this change. It seems to cause the exact issue its attempting to fix in some apps, likely because they're already working around it somehow. It'll take some work to land |
Fixes #30279
Note: this only affects icon buttons that have the
mat-unthemedclass.