fix(material/form-field): move error aria-live to parent container #30678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adolgachev
changed the title
adolgachev
added
dev-app preview
|
Deployed dev-app for 84a4502 to: https://ng-dev-previews-comp--pr-angular-components-30678-dev-b0shuu6t.web.app Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt. |
adolgachev
requested review from
crisbeto,
wagnermaciel and
andrewseguin
and removed request for
a team
crisbeto
approved these changes
Mar 24, 2025
fix(material/form-field): move error aria-live to parent container restructure errors Use single wrapper with aria-live update specs fix error update api goldens Add comment for new div
|
TESTED=TGP |
adolgachev
added
action: merge
|
Caretaker note: Needs to be merged with cl/739512259 |
|
The changes were merged into the following branches: main, 19.2.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a slight change in behavior where the aria-live is always set to polite even if the user puts a different aria-live value on the error. Based on internal usage, this is very rare (and not part of the documented API)
Fixes #29616
Revised version of #30155 which uses a single aria-live wrapper container div for both error and hints (changing the class appropriately). This prevents issues with existing usage caused by introducing a new wrapper div.