fix(cdk-experimental/listbox): initial listbox focus state#30764
Merged
wagnermaciel merged 2 commits intoangular:mainfrom Apr 23, 2025
Merged
fix(cdk-experimental/listbox): initial listbox focus state#30764wagnermaciel merged 2 commits intoangular:mainfrom
wagnermaciel merged 2 commits intoangular:mainfrom
Conversation
Contributor
wagnermaciel
commented
Apr 1, 2025
wagnermaciel
commented
- The first option to receive focus in a listbox should be either the first selected option or the first option in the list if no option is selected.
wagnermaciel
added
the
target: major
wagnermaciel
force-pushed
the
ng-aria-listbox
branch
from
82798bd to
c2019dc
Compare
wagnermaciel
requested review from
andrewseguin,
crisbeto and
mmalerba
and removed request for
a team
andrewseguin
approved these changes
Apr 14, 2025
mmalerba
approved these changes
Apr 21, 2025
Contributor
|
@wagnermaciel needs rebase |
* The first option to receive focus in a listbox should be either the first focusable selected option or the first focusable option in the list if no focusable selected option exists.
wagnermaciel
force-pushed
the
ng-aria-listbox
branch
from
164ad3c to
18a7192
Compare
Contributor
Author
|
@andrewseguin @mmalerba Re-requesting review because when rebasing I found & fixed an issue where disabled items could get selected. I added unit tests to ensure the active index can only gets set to focusable options. |
mmalerba
approved these changes
Apr 23, 2025
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.