Use full pnpm and integrate material.angular.io docs site into monorepo #30860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angular-robot
bot
added
the
area: build & ci
devversion
force-pushed
the
remove-yarn
branch
5 times, most recently
from
a06a481 to
e6f5d1d
Compare
devversion
added
action: review
devversion
requested review from
a team,
andrewseguin and
jelbourn
as code owners
|
FYI: I've been considering moving the docs site into |
devversion
force-pushed
the
remove-yarn
branch
2 times, most recently
from
363b92e to
0d0e9c5
Compare
|
closing/reopening to trigger CI... |
devversion
force-pushed
the
remove-yarn
branch
2 times, most recently
from
916648a to
8b330cf
Compare
josephperrott
approved these changes
Apr 14, 2025
| const params = fs.readFileSync(paramFilePath, 'utf-8').split('\n').map(unquoteParameter); | ||
| const [ | ||
| // Output directory for the npm package. | ||
| - outputDirExecPath, |
There was a problem hiding this comment.
It might not be worth changing since we are about to bring int a whole new ng_package toolset, but alot of these patch changes are just removing a single space, which makes it more brittle in theory, since the patch change has no actual effect.
There was a problem hiding this comment.
yeah, we will remove this soon anyway.
Final cleanup to remove Yarn in favor of pnpm. We resort to an extra Yarn package.json just for the remaining to-be-migrated `ng_package` rule and its dependencies. Everything else is full native `rules_js`.
Cleans up some unnecessary dependencies.
Renames the docs site from `material.angular.io` to `docs` so that it's easier to integrate into the Bazel.
Ignores the rename commit in the Git blame.
Integrates the `docs` site into the monorepo Bazel workspace.
This allows us to drop the yarn lock file etc. We only need to temporarily keep this for the older `ng_package` rule.
Fixes the docs lint setup to work. It failed due to some missing dependencies in pnpm. We should consider dropping this and just use Prettier IMO. Although I can see some useful linting of Angular specific code.
Updates docs deployment to rely on the Bazel monorepo.
Replaces usgaes of `yarn` with `pnpm` and updates documentation where necessary.
The patches are no longer needed. For tsec itself we need to come up with a whole new Starlark file. It's not even wired up right now.
The legacy bundle creation relies on `@angular/build-tooling`. As ideally we don't have any of such scripts, that rely on build tooling outside of Bazel, we simply add our own simple linker ESBuild plugin, while we save on complexity by using our existing tsconfig for path mappings. if we find more scripts needing build tooling scripts outside of Bazel that aren't legacy tooling, we should come up with a better solution.
ng-dev wasn't explicitly listing a dependency it relied upon. This commit updates to the latest version containing the fix.
This commit works around a strict dependency issue caused by the `@google-cloud/spanner` library. See: GoogleCloudPlatform/grpc-gcp-node#187.
`ng-dev` requires it to be an explicit dependency, and this also makes sense for IDEs picking up the version.
devversion
added
action: merge
We are now on full pnpm, so this is no longer needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.