fix(material/dialog): dialog's container-color does not follow Material 3 design specs #31271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…al 3 design specs Fixes a bug in the Angular Material dialog component where dialog uses `surface` container-color instead of `surface-container-high` as per Material 3 guidelines. Fixes angular#30536
jjalbuenacabuyao
requested review from
crisbeto and
mmalerba
and removed request for
a team
andrewseguin
approved these changes
Jun 1, 2025
adolgachev
added
requires: TGP
Contributor
|
FYI this is causing a fair number of internal tests to fail. |
adolgachev
added
the
presubmit failures
Contributor
|
This is still pending but I'll take a look this week as I'm back on rotation and try to fix the tests and merge if possible. |
Contributor
|
This does cause a lot of churn internally. In some cases unfortunately, the change in background conflicts with overlays on top of it (like date-picker). We'll need some more time to see how it could be rolled out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug in the Angular Material dialog component where dialog uses
surfacecontainer-color instead ofsurface-container-highas per Material 3 guidelines.Fixes #30536