Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(overlay): backdrop blocking element scroll #7779

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

crisbeto
Copy link
Member

Fixes a long-standing where the backdrop doesn't allow the user to scroll, if the main scrollable container is not the body.

Fixes #6927.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 13, 2017
@jelbourn jelbourn added the target: major This PR is targeted for the next major release label Oct 27, 2017
@jelbourn
Copy link
Member

jelbourn commented Oct 27, 2017

I agree we should do this long term, but I a bit hesitant to do it before stable because I suspect many Google apps have come to expect the current behavior and would need to switch to BlockScrollStrategy. It will take us some time to communicate the change and have make sure people are getting the behavior they want. I'm thinking this should go on the list for susequent major release.

@crisbeto
Copy link
Member Author

crisbeto commented Mar 5, 2018

@jelbourn just remembered about this one. Should we schedule it for 6.0?

@jelbourn
Copy link
Member

jelbourn commented Mar 5, 2018

I don't think we have time before 6.0 to track down the stuff I mentioned above

@ngbot
Copy link

ngbot bot commented Jul 11, 2018

Hi @crisbeto! This PR has merge conflicts due to recent upstream merges.
Please help to unblock it by resolving these conflicts. Thanks!

1 similar comment
@ngbot
Copy link

ngbot bot commented Jul 11, 2018

Hi @crisbeto! This PR has merge conflicts due to recent upstream merges.
Please help to unblock it by resolving these conflicts. Thanks!

@ngbot
Copy link

ngbot bot commented Aug 3, 2018

Hi @crisbeto! This PR has merge conflicts due to recent upstream merges.
Please help to unblock it by resolving these conflicts. Thanks!

@crisbeto
Copy link
Member Author

@jelbourn do we still want to do this?

@jelbourn
Copy link
Member

I'd say this is lower priority than the other stuff we're doing for v7. If we're able to wrap up the visual changes and other stuff, we can see about getting this in.

@nadhir-falta
Copy link

Any work around for this please ?

@hilnius
Copy link

hilnius commented Jan 29, 2019

any idea in which release can this PR make its way ?

@mmalerba mmalerba added aaa and removed aaa labels Apr 25, 2019
@andrewseguin andrewseguin added the P4 A relatively minor issue that is not relevant to core functions label May 30, 2019
Fixes a long-standing where the backdrop doesn't allow the user to scroll, if the main scrollable container is not the body.

Fixes angular#6927.
@kokojvanko
Copy link

Any idea when this will make it in? I really want to use the components from Angular material, but this is kind of a blocker...

@rppig42
Copy link

rppig42 commented Feb 14, 2020

Is there any update about this PR ?

Angular CDK is not only the base of Angular Material but also many other Angular UI libraries. The current behavior makes Angular Material websites different from other Material Design products like Google Keep.

@gokhanoner
Copy link

@jelbourn, this is a long standing issue which prevents us & many to use this functionality. If you have no intension to implement it, please also let us know so we take it under consideration when using related material components.

@jelbourn
Copy link
Member

jelbourn commented Apr 23, 2020

The problem with this change is that it's very difficult/breaking to land in Google, and there's a number of higher priority items that keep this (and many fixes of a similar nature) from being worked on.

@gokhanoner
Copy link

I see. Thanks @jelbourn . I believe I can think of this as a wont-fixed issue then.

@CnxYankoNikolov
Copy link

What is the prospect of making all those private functions protected, so we can at least extend the classes, apply this fix and provide them instead of the default ones? That way we can override the behavior, without changing the default one.

@andrewseguin andrewseguin removed the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 29, 2021
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 29, 2021
@andrewseguin andrewseguin removed the P4 A relatively minor issue that is not relevant to core functions label Mar 28, 2022
@josephperrott josephperrott added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed needs rebase labels Nov 16, 2022
@josephperrott josephperrott requested a review from a team as a code owner December 18, 2024 17:40
@josephperrott josephperrott requested review from andrewseguin and removed request for a team December 18, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews cla: yes PR author has agreed to Google's Contributor License Agreement target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Open menu should support background scrolling