-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(overlay): backdrop blocking element scroll #7779
base: main
Are you sure you want to change the base?
Conversation
I agree we should do this long term, but I a bit hesitant to do it before stable because I suspect many Google apps have come to expect the current behavior and would need to switch to |
6040d03
to
b52ee9a
Compare
@jelbourn just remembered about this one. Should we schedule it for 6.0? |
I don't think we have time before 6.0 to track down the stuff I mentioned above |
Hi @crisbeto! This PR has merge conflicts due to recent upstream merges. |
1 similar comment
Hi @crisbeto! This PR has merge conflicts due to recent upstream merges. |
0491a0f
to
3ee06f6
Compare
Hi @crisbeto! This PR has merge conflicts due to recent upstream merges. |
3ee06f6
to
06d2d4a
Compare
@jelbourn do we still want to do this? |
I'd say this is lower priority than the other stuff we're doing for v7. If we're able to wrap up the visual changes and other stuff, we can see about getting this in. |
06d2d4a
to
0afa5b8
Compare
Any work around for this please ? |
0afa5b8
to
ba94b3c
Compare
any idea in which release can this PR make its way ? |
ba94b3c
to
2e2d811
Compare
Fixes a long-standing where the backdrop doesn't allow the user to scroll, if the main scrollable container is not the body. Fixes angular#6927.
2e2d811
to
e0de1ed
Compare
Any idea when this will make it in? I really want to use the components from Angular material, but this is kind of a blocker... |
Is there any update about this PR ? Angular CDK is not only the base of Angular Material but also many other Angular UI libraries. The current behavior makes Angular Material websites different from other Material Design products like Google Keep. |
@jelbourn, this is a long standing issue which prevents us & many to use this functionality. If you have no intension to implement it, please also let us know so we take it under consideration when using related material components. |
The problem with this change is that it's very difficult/breaking to land in Google, and there's a number of higher priority items that keep this (and many fixes of a similar nature) from being worked on. |
I see. Thanks @jelbourn . I believe I can think of this as a wont-fixed issue then. |
What is the prospect of making all those private functions protected, so we can at least extend the classes, apply this fix and provide them instead of the default ones? That way we can override the behavior, without changing the default one. |
Fixes a long-standing where the backdrop doesn't allow the user to scroll, if the main scrollable container is not the body.
Fixes #6927.