Upgrade to jasmine 3.1.0 #4789

awarecan · 2018-04-27T02:42:27Z

resolve #4788

Jamine 3 change the random default to true, however I want to keep protractor's default to false to avoid breaking changes.

googlebot · 2018-04-27T02:42:31Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

googlebot · 2018-04-27T02:42:31Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

awarecan · 2018-04-27T02:50:15Z

I signed it!

googlebot · 2018-04-27T02:50:18Z

CLAs look good, thanks!

googlebot · 2018-04-27T02:50:18Z

CLAs look good, thanks!

done() accept error as parameter in Jasmine 3 beforeEach() no longer allow in it() in Jasmine 3

slightly modify slowHttpAndTimeoutConf.js test expectation

awarecan · 2018-04-28T03:14:46Z

resolved #4708 as well

qiyigg · 2018-05-10T20:06:42Z

package.json

@@ -18,7 +18,7 @@
    "blocking-proxy": "^1.0.0",
    "chalk": "^1.1.3",
    "glob": "^7.0.3",
-    "jasmine": "2.8.0",
+    "jasmine": "3.1.0",


Please also update package-lock.json

qiyigg · 2018-05-10T20:07:12Z

spec/unit/driverProviders/local_test.js

@@ -65,7 +65,6 @@ describe('local connect', function() {
          webdriver.getNewDriver();
        } catch(e) {
          errorFound = true;
-          expect(e.code).toBe(BrowserError.CODE);


why remove this?

The purpose of this test is validate if error be thrown, not to verify the error code. I am not sure what is the root cause, but the exception don't have code property on my environment, the test will fail.

qiyigg · 2018-05-10T20:09:10Z

spec/unit/runner_test.js

@@ -65,6 +65,6 @@ describe('the Protractor runner', function() {
    var runner = new Runner(config);
    runner.run().then(function() {
      done.fail('expected error when no custom framework is defined');
-    }, done);
+    }, done());


The "then" function receives a Function as parameter, passing done() to it will call "done" first and make the test always pass, won't it?

This test is expecting exception thrown, so if error occurred, done(), test passed.
One big change in Jasmine 3 is done() accept one parameter now, if we pass done function here, done(e) will be called, Jasmine will fail the test. Alternative change here is

runner.run().then(function() { done.fail('expected error when no custom framework is defined'); }, () => {return done();} );

…ttp (angular#4793)

…und. (angular#4800)

Updated some of the spelling errors/ punctuation mistakes for clearer understanding.

Increase the scripts timeout

googlebot · 2018-05-10T23:21:51Z

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

googlebot · 2018-05-10T23:21:51Z

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

awarecan · 2018-05-10T23:24:44Z

Seems I messed up the PR... don't known why the saucelab related changes appear here. I will close this for now

upgrade to jasmine 3.1

adc5e5a

googlebot added the cla: no label Apr 27, 2018

googlebot added cla: yes and removed cla: no labels Apr 27, 2018

awarecan added 2 commits April 27, 2018 18:49

unit test fix

4336c9a

done() accept error as parameter in Jasmine 3 beforeEach() no longer allow in it() in Jasmine 3

fix test

f2b4932

slightly modify slowHttpAndTimeoutConf.js test expectation

qiyigg reviewed May 10, 2018

View reviewed changes

awarecan and others added 6 commits May 10, 2018 16:02

Update package-lock.json

efab439

updated CHANGELOG based on sauceSeleniumAddress and sauceSeleniumUseH…

13c07e1

…ttp (angular#4793)

fix(cli): add more verbose warning if '_debugger' module cannot be fo…

24e5c5d

…und. (angular#4800)

fix(doc): Spelling updates to comments in plugin.ts(angular#4797)

de7ece7

Updated some of the spelling errors/ punctuation mistakes for clearer understanding.

fix(deps): Update saucelabs for security issue. (angular#4805)

63ed18b

fix(test): fix async tests (angular#4806)

db9e198

Increase the scripts timeout

googlebot added cla: no and removed cla: yes labels May 10, 2018

awarecan closed this May 10, 2018

awarecan deleted the jasmine-3 branch May 10, 2018 23:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade to jasmine 3.1.0 #4789

Upgrade to jasmine 3.1.0 #4789

awarecan commented Apr 27, 2018

googlebot commented Apr 27, 2018

googlebot commented Apr 27, 2018

awarecan commented Apr 27, 2018

googlebot commented Apr 27, 2018

googlebot commented Apr 27, 2018

awarecan commented Apr 28, 2018

qiyigg May 10, 2018

qiyigg May 10, 2018

awarecan May 10, 2018

qiyigg May 10, 2018

awarecan May 10, 2018

googlebot commented May 10, 2018

googlebot commented May 10, 2018

awarecan commented May 10, 2018

Upgrade to jasmine 3.1.0 #4789

Upgrade to jasmine 3.1.0 #4789

Conversation

awarecan commented Apr 27, 2018

googlebot commented Apr 27, 2018

What to do if you already signed the CLA

Individual signers

Corporate signers

googlebot commented Apr 27, 2018

What to do if you already signed the CLA

Individual signers

Corporate signers

awarecan commented Apr 27, 2018

googlebot commented Apr 27, 2018

googlebot commented Apr 27, 2018

awarecan commented Apr 28, 2018

qiyigg May 10, 2018

Choose a reason for hiding this comment

qiyigg May 10, 2018

Choose a reason for hiding this comment

awarecan May 10, 2018

Choose a reason for hiding this comment

qiyigg May 10, 2018

Choose a reason for hiding this comment

awarecan May 10, 2018

Choose a reason for hiding this comment

googlebot commented May 10, 2018

googlebot commented May 10, 2018

awarecan commented May 10, 2018