chore: add better age_over_NN attributes #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auer-martin
approved these changes
Jan 29, 2025
TimoGlastra
reviewed
Jan 29, 2025
| // Values defined in: https://bmi.usercontent.opencode.de/eudi-wallet/eidas-2.0-architekturkonzept/functions/00-pid-issuance-and-presentation/#pid-contents | ||
| // ISO/IEC 18013-5: 7.2.5 does not define which ages should be included. | ||
|
|
||
| addAgePredicate(12) |
There was a problem hiding this comment.
Should this be defined by this library? Why not just leave it to the user / implementer of this library?
There was a problem hiding this comment.
Yeah that can also work, but maybe @auer-martin could pick that up. I am not really aware of the correct API changes that need to be made for this.
|
Can you add a changeset (breaking, minor) indicating what is fixed? |
Signed-off-by: Berend Sliedrecht <[email protected]>
berendsliedrecht
force-pushed
the
better-age-over-attrs
branch
from
0d3d6d2 to
bb18150
Compare
🦋 Changeset detectedLatest commit: 1b4308f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…_over_<CURRENT_AGE> Signed-off-by: Berend Sliedrecht <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Berend Sliedrecht [email protected]