Coding: Develop a timeline for programs page (#73) #150

iamkryptonite · 2020-10-19T06:30:14Z

Description

Developed a timeline for the events page.

Fixes #73

Type of Change:

Delete irrelevant options.

Code
User Interface

Code/Quality Assurance Only

Bugfix (a non-breaking change that fixes an issue)
This change requires a documentation update (software upgrade on readme file)
New feature (non-breaking change which adds functionality pre-approved by mentors)

How Has This Been Tested?

Describe the tests you ran to verify your changes. Provide instructions or GIFs so we can reproduce. List any relevant details for your test.

gh-pages Link: https://iamkryptonite.github.io/anitab-org.github.io/

Checklist:

Delete irrelevant options.

My PR follows the style guidelines of this project
I have performed a self-review of my own code or materials
I have commented on my code or provided relevant documentation, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
Any dependent changes have been merged

Code/Quality Assurance Only

My changes generate no new warnings
My PR currently breaks something (fix or feature that would cause existing functionality to not work as expected)
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes
Any dependent changes have been published in downstream modules

src/Components/Programs/Timeline.js

annabauza · 2020-10-24T14:06:19Z

this looks great we just need to tweak the code a bit

iamkryptonite · 2020-11-25T04:12:31Z

Hey @annabauza I have made the necessary changes in the code ,could you please review it once

nandini45 · 2020-12-07T15:34:42Z

@Bucky25 can you review this one?

src/Components/Programs/Timeline.js

Bucky25 · 2020-12-08T06:03:37Z

src/Components/Programs/styles.js

+})
+export const Months = styled(View,{
+    marginBottom:'15px',


please make it power of 2

Bucky25 · 2020-12-08T06:03:58Z

src/Components/Programs/styles.js

please make it power of 2

and please add a link to your deployed gh pages

gh-pages link: https://iamkryptonite.github.io/anitab-org.github.io/

annabauza

Generally very good code. I have left you mostly notes related to css. Thanks.

src/Components/Programs/styles.js

src/Components/Programs/Timeline.js

iamkryptonite · 2020-12-28T06:13:55Z

Hi, it looks like the PR will work only for the web version. We should not use things like classes and jQuery in React Native. Please do these changes.
Thanks

Hi,I have made the changes. Please review once. @tichnas

tichnas · 2020-12-28T09:16:57Z

@iamkryptonite I think you're still using jQuery and pixels which don't go well with React Native. Can you please change them also?
Thanks for giving time to do these changes :)

iamkryptonite · 2020-12-28T17:59:09Z

@iamkryptonite I think you're still using jQuery and pixels which don't go well with React Native. Can you please change them also?
Thanks for giving time to do these changes :)

Hi @tichnas, I have removed jquery and used useRef instead. And I have also changed all the places where pixels were used.

annabauza

💯 This is great thank you!

annabauza · 2021-01-01T13:38:20Z

@iamkryptonite please call yarn in command line and commit yarn.lock because travis is failing.

tichnas

Please commit the changes to yarn.lock (and don't delete the file)
Also, remove your homepage link from package.json and can you please tell what's @babel/plugin-transform-react-jsx used for?

Thanks

iamkryptonite · 2021-01-03T10:41:26Z

Please commit the changes to yarn.lock (and don't delete the file)
Also, remove your homepage link from package.json and can you please tell what's @babel/plugin-transform-react-jsx used for?

Thanks

Hey, I have made the requested changes and also removed the babel package as it was not required.

annabauza

please resolve conflict and merge with existing events tab. Thanks!

annabauza

Generally OK for first iteration just a quick question does homepage change would not break github static pages?

annabauza · 2021-01-23T22:20:13Z

package.json

@@ -1,11 +1,13 @@
 {
-  "homepage": "./",
+  "homepage": "/",


Why this change?

I am not really sure, I think this was a mistake so have changed it.

Vishal-raj-1

Great Work @iamkryptonite !! Could you please squash your commits

annabauza · 2021-01-31T10:52:39Z

@Vishal-raj-1 we are squashing comments on merge, no need to do that.

…nitab-org#150)" This reverts commit a26b10c.

iamkryptonite · 2021-01-31T16:18:25Z

Hey @annabauza there is one small change that I need to make in my code.

annabauza · 2021-01-31T16:19:26Z

Rise the issue and ask to be assigned

iamkryptonite · 2021-03-01T12:11:59Z

Rise the issue and ask to be assigned

Hey @annabauza I have raised the issue. Could you pls approve it and add relevant labels.
Thanks.

iamkryptonite added 11 commits September 23, 2020 12:01

feat: added timeline for programs

806f2a0

fixed timeline ui issues

8043c3c

added scroll view

773f73d

added marker and fade

6a93f00

added arrows for scrolling

e88414a

fixed everything

abb12b1

added stroke

ea82321

added current date

3c76396

fixed date format

ad751c9

added months

f0aafc1

Feat: Develope timeline for the programs page (anitab-org#73)

b3dc12a

annabauza reviewed Oct 24, 2020

View reviewed changes

src/Components/Programs/Timeline.js Outdated Show resolved Hide resolved

annabauza reviewed Oct 24, 2020

View reviewed changes

src/Components/Programs/Timeline.js Show resolved Hide resolved

annabauza reviewed Oct 24, 2020

View reviewed changes

src/Components/Programs/Timeline.js Outdated Show resolved Hide resolved

annabauza reviewed Oct 24, 2020

View reviewed changes

src/Components/Programs/Timeline.js Outdated Show resolved Hide resolved

iamkryptonite added 2 commits October 25, 2020 11:23

moved events and months to contents/programs_events

360bde2

refractored styles

526fbf2

iamkryptonite requested a review from annabauza October 27, 2020 13:41

Akanksha1212 added the Status: Needs Review PR needs an additional review or a maintainer's review. label Oct 31, 2020

Bucky25 suggested changes Dec 8, 2020

View reviewed changes

iamkryptonite added 6 commits December 11, 2020 00:35

fixed styles

d18e579

gh-pages

475496b

style changes

125f1f4

Merge branch 'xxx' into master

5e0e3b1

style changes

5d7a52c

Merge branch 'xxx' into master

0e3aadb

annabauza requested changes Dec 26, 2020

View reviewed changes

fixed scroller,removed jquery

012d2f8

iamkryptonite requested a review from annabauza December 28, 2020 06:10

iamkryptonite added 2 commits December 28, 2020 15:17

fixed css issues

f6d52ce

minor changes

66d8b40

annabauza approved these changes Jan 1, 2021

View reviewed changes

iamkryptonite added 2 commits January 1, 2021 23:56

added yarn lock

c586501

minor changes

76fe6cc

tichnas suggested changes Jan 1, 2021

View reviewed changes

minor changes

31141d0

annabauza requested changes Jan 17, 2021

View reviewed changes

annabauza added Status: Changes Requested Changes are required to be done by the PR author. and removed Status: Needs Review PR needs an additional review or a maintainer's review. labels Jan 17, 2021

resolved conflicts

fd82971

iamkryptonite requested a review from annabauza January 19, 2021 04:40

annabauza approved these changes Jan 23, 2021

View reviewed changes

minor changes

cd5884a

Vishal-raj-1 approved these changes Jan 29, 2021

View reviewed changes

annabauza approved these changes Jan 31, 2021

View reviewed changes

annabauza merged commit a26b10c into anitab-org:develop Jan 31, 2021

iamkryptonite added a commit to iamkryptonite/anitab-org.github.io that referenced this pull request Jan 31, 2021

Revert "Coding: Develop a timeline for programs page (anitab-org#73) (a…

0286044

…nitab-org#150)" This reverts commit a26b10c.

iamkryptonite mentioned this pull request Mar 1, 2021

Bug: Timeline in 'Programs' page is breaking #246

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Coding: Develop a timeline for programs page (#73) #150

Coding: Develop a timeline for programs page (#73) #150

iamkryptonite commented Oct 19, 2020 •

edited

Loading

annabauza commented Oct 24, 2020

iamkryptonite commented Nov 25, 2020

nandini45 commented Dec 7, 2020

Bucky25 Dec 8, 2020

iamkryptonite Dec 10, 2020

Bucky25 Dec 8, 2020

Bucky25 Dec 8, 2020

iamkryptonite Dec 12, 2020

annabauza left a comment

iamkryptonite commented Dec 28, 2020 •

edited

Loading

tichnas commented Dec 28, 2020

iamkryptonite commented Dec 28, 2020

annabauza left a comment

annabauza commented Jan 1, 2021

tichnas left a comment

iamkryptonite commented Jan 3, 2021

annabauza left a comment

annabauza left a comment

annabauza Jan 23, 2021

iamkryptonite Jan 26, 2021

Vishal-raj-1 left a comment

annabauza commented Jan 31, 2021

iamkryptonite commented Jan 31, 2021

annabauza commented Jan 31, 2021

iamkryptonite commented Mar 1, 2021

Coding: Develop a timeline for programs page (#73) #150

Coding: Develop a timeline for programs page (#73) #150

Conversation

iamkryptonite commented Oct 19, 2020 • edited Loading

Description

Type of Change:

How Has This Been Tested?

Checklist:

annabauza commented Oct 24, 2020

iamkryptonite commented Nov 25, 2020

nandini45 commented Dec 7, 2020

Bucky25 Dec 8, 2020

Choose a reason for hiding this comment

iamkryptonite Dec 10, 2020

Choose a reason for hiding this comment

Bucky25 Dec 8, 2020

Choose a reason for hiding this comment

Bucky25 Dec 8, 2020

Choose a reason for hiding this comment

iamkryptonite Dec 12, 2020

Choose a reason for hiding this comment

annabauza left a comment

Choose a reason for hiding this comment

iamkryptonite commented Dec 28, 2020 • edited Loading

tichnas commented Dec 28, 2020

iamkryptonite commented Dec 28, 2020

annabauza left a comment

Choose a reason for hiding this comment

annabauza commented Jan 1, 2021

tichnas left a comment

Choose a reason for hiding this comment

iamkryptonite commented Jan 3, 2021

annabauza left a comment

Choose a reason for hiding this comment

annabauza left a comment

Choose a reason for hiding this comment

annabauza Jan 23, 2021

Choose a reason for hiding this comment

iamkryptonite Jan 26, 2021

Choose a reason for hiding this comment

Vishal-raj-1 left a comment

Choose a reason for hiding this comment

annabauza commented Jan 31, 2021

iamkryptonite commented Jan 31, 2021

annabauza commented Jan 31, 2021

iamkryptonite commented Mar 1, 2021

iamkryptonite commented Oct 19, 2020 •

edited

Loading

iamkryptonite commented Dec 28, 2020 •

edited

Loading