Add Hebrew deck translation#735
Conversation
aplaice
left a comment
There was a problem hiding this comment.
Thanks very much! Unfortunately, I can't review the actual translations, but the "plumbing" all looks fine! (Good catch on the previously unreplaced Hint in the template! Thanks!)
For the card text direction, we could probably also set it via css, rather than the div dirs but it'd require templating of the CSS, so this is probably simpler (and probably more flexible (?), in case we ever need mixed text direction in cards).
Awesome, thanks! Yeah, I figured the divs were the safest bet for flexibility. |
We usually wait a while in case anyone else has additional feedback (especially from the core team), but given that none of the core team speaks Hebrew and given that there's a chance of significant structural changes in the near future, I'm merging this now. (If there's need we can always edit later.) May I add you to the translators list? |
Sure, no problem. |
Summary
HE) as a supported language across note data, note model metadata, deck recipes, deck descriptions, and documentation.__TEXT_DIRECTION__and__IS_RIGHT_TO_LEFT__.Implementation
src/note_models/translations.csvnow includes text direction metadata for all languages and Hebrew template substitutions.is_right_to_leftmetadata where applicable.dir="__TEXT_DIRECTION__"so Hebrew cards render right-to-left while existing languages remain left-to-right.recipes/source_to_anki.yamlandrecipes/source_to_anki_[experimental].yamlnow build Hebrew decks and includeguid:he.src/headers/desc_he.htmlis tracked as a static localized deck description, matching the pattern used by the other deck descriptions.CONTRIBUTING.mddocuments the Hebrew translation source convention.