Skip to content

Add Hebrew deck translation#735

Merged
aplaice merged 4 commits into
anki-geo:masterfrom
mikecrawford99:add-hebrew-language
May 27, 2026
Merged

Add Hebrew deck translation#735
aplaice merged 4 commits into
anki-geo:masterfrom
mikecrawford99:add-hebrew-language

Conversation

@mikecrawford99
Copy link
Copy Markdown
Contributor

Summary

  • Add Hebrew (HE) as a supported language across note data, note model metadata, deck recipes, deck descriptions, and documentation.
  • Add reusable RTL support to the generated note model templates via __TEXT_DIRECTION__ and __IS_RIGHT_TO_LEFT__.
  • Add Hebrew translations for countries, capitals, country/capital info, capital hints, and flag similarity text.
  • Add Hebrew deck builds for standard, extended, and experimental variants.
  • Add a static Hebrew deck description and update existing deck descriptions/README language lists to include Hebrew.

Implementation

  • src/note_models/translations.csv now includes text direction metadata for all languages and Hebrew template substitutions.
  • Textual Anki fields now receive is_right_to_left metadata where applicable.
  • Card templates wrap rendered card content in dir="__TEXT_DIRECTION__" so Hebrew cards render right-to-left while existing languages remain left-to-right.
  • recipes/source_to_anki.yaml and recipes/source_to_anki_[experimental].yaml now build Hebrew decks and include guid:he.
  • src/headers/desc_he.html is tracked as a static localized deck description, matching the pattern used by the other deck descriptions.
  • CONTRIBUTING.md documents the Hebrew translation source convention.

Copy link
Copy Markdown
Collaborator

@aplaice aplaice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much! Unfortunately, I can't review the actual translations, but the "plumbing" all looks fine! (Good catch on the previously unreplaced Hint in the template! Thanks!)

For the card text direction, we could probably also set it via css, rather than the div dirs but it'd require templating of the CSS, so this is probably simpler (and probably more flexible (?), in case we ever need mixed text direction in cards).

@mikecrawford99
Copy link
Copy Markdown
Contributor Author

@aplaice:

Thanks very much! Unfortunately, I can't review the actual translations, but the "plumbing" all looks fine! (Good catch on the previously unreplaced Hint in the template! Thanks!)

For the card text direction, we could probably also set it via css, rather than the div dirs but it'd require templating of the CSS, so this is probably simpler (and probably more flexible (?), in case we ever need mixed text direction in cards).

Awesome, thanks! Yeah, I figured the divs were the safest bet for flexibility.
Do you know around when you'll be able to merge this in?

@aplaice aplaice merged commit e1be2e9 into anki-geo:master May 27, 2026
1 check passed
@aplaice
Copy link
Copy Markdown
Collaborator

aplaice commented May 27, 2026

Do you know around when you'll be able to merge this in?

We usually wait a while in case anyone else has additional feedback (especially from the core team), but given that none of the core team speaks Hebrew and given that there's a chance of significant structural changes in the near future, I'm merging this now. (If there's need we can always edit later.)

May I add you to the translators list?

@mikecrawford99
Copy link
Copy Markdown
Contributor Author

Do you know around when you'll be able to merge this in?

We usually wait a while in case anyone else has additional feedback (especially from the core team), but given that none of the core team speaks Hebrew and given that there's a chance of significant structural changes in the near future, I'm merging this now. (If there's need we can always edit later.)

May I add you to the translators list?

Sure, no problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants