-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add light mode #23
Conversation
Thanks for looking into this - I imagine some users will much prefer this version. My only meagre suggestion is that the shade of blue in things like links could be slightly darker. |
I have tried several colors, but none of them fit, so this will be fixed in the future. |
I think we can probably make this change without needing much change to the markup. For example, given the following CSS this handles most of the required changes to support light mode (it's not finalised though): @layer base {
:root {
--foreground: 0, 0%, 0%;
--background: 0, 0%, 97%;
--primary: 205, 67%, 40%;
--primary-darker: 208, 65%, 50%;
}
@media (prefers-color-scheme: dark) {
:root {
--foreground: 0, 0%, 100%;
--background: 0, 0%, 3%;
--primary: 205, 67%, 70%;
--primary-darker: 208, 65%, 60%;
}
}
body {
@apply font-sans bg-background text-foreground;
}
}
@theme {
--font-sans: Outfit Variable, sans-serif;
--color-primary-darker: hsl(var(--primary-darker));
--color-foreground: hsl(var(--foreground));
--color-background: hsl(var(--background));
--color-primary: hsl(var(--primary));
--color-secondary: #968ca8;
--color-neutral: hsla(var(--foreground), 70%);
--color-error: #ff5449;
} |
This pull request is ready to be merged, but the background in dark mode will be darker again in accordance with Toby's suggestion.
P.S. I am flexible with the color choices because they are very opinionated. |
Sorry for the delay, and thank you again for this! I personally find the light mode to be a touch on the bright/washed-out side, but that may be just me - let's see how people find it :-) |
This iteration is still subject to changes.
